perf_hooks: fix PerformanceObserver gc crash

Signed-off-by: James M Snell <[email protected]>
Fixes: #39548

PR-URL: #39550
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

Author: jasnell

lib/internal/perf/observe.js

@@ -132,6 +132,7 @@ function maybeDecrementObserverCounts(entryTypes) {
       if (observerType === NODE_PERFORMANCE_ENTRY_TYPE_GC &&
           observerCounts[observerType] === 0) {
         removeGarbageCollectionTracking();
+        gcTrackingInstalled = false;
       }
     }
   }

test/parallel/test-perf-gc-crash.js

@@ -0,0 +1,25 @@
+'use strict';
+
+require('../common');
+
+// Refers to https://github.com/nodejs/node/issues/39548
+
+// The test fails if this crashes. If it closes normally,
+// then all is good.
+
+const {
+  PerformanceObserver,
+} = require('perf_hooks');
+
+// We don't actually care if the observer callback is called here.
+const gcObserver = new PerformanceObserver(() => {});
+
+gcObserver.observe({ entryTypes: ['gc'] });
+
+gcObserver.disconnect();
+
+const gcObserver2 = new PerformanceObserver(() => {});
+
+gcObserver2.observe({ entryTypes: ['gc'] });
+
+gcObserver2.disconnect();