Skip to content

Commit 8dec802

Browse files
targosMylesBorins
authored andcommitted
build: run test-hash-seed at the end of test-v8
The v8 and test-hash-seed targets cannot be run in parallel because they need different copies of the deps/v8 directory. Ref: #14004 (comment) PR-URL: #14219 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent a3e2560 commit 8dec802

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,13 +296,15 @@ test-timers-clean:
296296

297297

298298
ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
299-
test-v8: v8 test-hash-seed
299+
test-v8: v8
300300
# note: performs full test unless QUICKCHECK is specified
301301
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
302302
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \
303303
--no-presubmit \
304304
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
305305
$(TAP_V8)
306+
@echo Testing hash seed
307+
$(MAKE) test-hash-seed
306308

307309
test-v8-intl: v8
308310
# note: performs full test unless QUICKCHECK is specified

0 commit comments

Comments
 (0)