src: make AliasedBuffers in the binding data weak

joyeecheung · legendecas · web-flow · commit 7b9a1ef9d956 · 2023-04-04T16:51:46.000+02:00
Co-authored-by: Chengzhong Wu &lt;legendecas@gmail.com&gt;
diff --git a/src/aliased_buffer-inl.h b/src/aliased_buffer-inl.h
@@ -132,6 +132,7 @@ inline void AliasedBufferBase<NativeT, V8T>::WeakCallback(
   AliasedBufferBase<NativeT, V8T>* buffer = data.GetParameter();
   DCHECK(buffer->is_valid());
   buffer->cleared_ = true;
+  js_array_.Reset();
 }
 
 template <typename NativeT, typename V8T>

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,7 @@ inline void AliasedBufferBase<NativeT, V8T>::WeakCallback(`
`132`	`132`	`AliasedBufferBase<NativeT, V8T>* buffer = data.GetParameter();`
`133`	`133`	`DCHECK(buffer->is_valid());`
`134`	`134`	`buffer->cleared_ = true;`
	`135`	`+ js_array_.Reset();`
`135`	`136`	`}`
`136`	`137`
`137`	`138`	`template <typename NativeT, typename V8T>`