Skip to content

Commit 7ad5787

Browse files
committed
http: clean up HttpParser correctly
remove reference to kOnMessageBegin from HttpParser to avoid leaking Server instances in FreeList
1 parent 4de6f20 commit 7ad5787

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

lib/_http_common.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ let debug = require('internal/util/debuglog').debuglog('http', (fn) => {
4646

4747
const kIncomingMessage = Symbol('IncomingMessage');
4848
const kRequestTimeout = Symbol('RequestTimeout');
49+
const kOnMessageBegin = HTTPParser.kOnMessageBegin | 0;
4950
const kOnHeaders = HTTPParser.kOnHeaders | 0;
5051
const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
5152
const kOnBody = HTTPParser.kOnBody | 0;
@@ -239,6 +240,7 @@ function cleanParser(parser) {
239240
parser.incoming = null;
240241
parser.outgoing = null;
241242
parser.maxHeaderPairs = MAX_HEADER_PAIRS;
243+
parser[kOnMessageBegin] = null;
242244
parser[kOnExecute] = null;
243245
parser[kOnTimeout] = null;
244246
parser._consumed = false;

0 commit comments

Comments
 (0)