Skip to content

Commit 6418042

Browse files
KhafraDevaduh95
authored andcommitted
events: getMaxListeners detects 0 listeners
PR-URL: #56807 Refs: nodejs/undici#4032 Refs: c1ccade Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
1 parent 3095db8 commit 6418042

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/events.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -950,7 +950,7 @@ function getEventListeners(emitterOrTarget, type) {
950950
function getMaxListeners(emitterOrTarget) {
951951
if (typeof emitterOrTarget?.getMaxListeners === 'function') {
952952
return _getMaxListeners(emitterOrTarget);
953-
} else if (emitterOrTarget?.[kMaxEventTargetListeners]) {
953+
} else if (typeof emitterOrTarget?.[kMaxEventTargetListeners] === 'number') {
954954
return emitterOrTarget[kMaxEventTargetListeners];
955955
}
956956

test/parallel/test-events-getmaxlisteners.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,8 @@ const { getMaxListeners, EventEmitter, defaultMaxListeners, setMaxListeners } =
1717
setMaxListeners(101, et);
1818
assert.strictEqual(getMaxListeners(et), 101);
1919
}
20+
21+
{
22+
const ac = new AbortController();
23+
assert.strictEqual(getMaxListeners(ac.signal), 0);
24+
}

0 commit comments

Comments
 (0)