Skip to content

Commit 0179d35

Browse files
joyeecheungnodejs-github-bot
authored andcommitted
build: set v8_enable_verify_write_barriers for debug builds
It otherwise doesn't build.
1 parent 00a2789 commit 0179d35

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

configure.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1876,6 +1876,7 @@ def configure_v8(o, configs):
18761876
if sys.platform != 'darwin':
18771877
if o['variables']['v8_enable_webassembly'] and o['variables']['target_arch'] == 'x64':
18781878
o['variables']['v8_enable_wasm_simd256_revec'] = 1
1879+
o['variables']['v8_enable_verify_write_barriers'] = 1 if options.debug else 0
18791880

18801881
def configure_openssl(o):
18811882
variables = o['variables']

tools/v8_gypfiles/features.gypi

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,10 @@
153153
# Use pre-generated static root pointer values from static-roots.h.
154154
'v8_enable_static_roots%': 0,
155155

156+
# Disable write barriers when GCs are non-incremental and
157+
# heap has single generation.
158+
'v8_enable_verify_write_barriers%': 0,
159+
156160
# Enable code-generation-time checking of types in the CodeStubAssembler.
157161
'v8_enable_verify_csa%': 0,
158162

@@ -430,6 +434,9 @@
430434
['v8_enable_single_generation==1', {
431435
'defines': ['V8_ENABLE_SINGLE_GENERATION',],
432436
}],
437+
['v8_enable_verify_write_barriers==1', {
438+
'defines': ['V8_VERIFY_WRITE_BARRIERS',],
439+
}],
433440
['v8_disable_write_barriers==1', {
434441
'defines': ['V8_DISABLE_WRITE_BARRIERS',],
435442
}],

0 commit comments

Comments
 (0)