feat: prohibit compiling with ClangCL on Windows (#3098)

StefanStojanovic · lukekarrys · commit 045cb8673314 · 2024-12-02T12:56:59.000-07:00
Disables trying to compile with ClangCL on Windows. Was required to enable native tests in the Node.js CI for the ClangCL produced binaries. Refs: nodejs/node#55784
diff --git a/lib/create-config-gypi.js b/lib/create-config-gypi.js
@@ -96,6 +96,9 @@ async function getCurrentConfigGypi ({ gyp, nodeDir, vsInfo, python }) {
       }
     }
     variables.msbuild_path = vsInfo.msBuild
+    if (config.variables.clang === 1) {
+      config.variables.clang = 0
+    }
   }
 
   // loop through the rest of the opts and add the unknown ones as variables.

Original file line number	Diff line number	Diff line change
`@@ -96,6 +96,9 @@ async function getCurrentConfigGypi ({ gyp, nodeDir, vsInfo, python }) {`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`	`variables.msbuild_path = vsInfo.msBuild`
	`99`	`+ if (config.variables.clang === 1) {`
	`100`	`+ config.variables.clang = 0`
	`101`	`+ }`
`99`	`102`	`}`
`100`	`103`
`101`	`104`	`// loop through the rest of the opts and add the unknown ones as variables.`