Skip to content

Commit 6f53aea

Browse files
committed
jenkins: move HTTP assertions from .tearDown() alongside response test
As it's way more intuitive to have those outgoing HTTP request assertions alongside other assertions, than as part of the test tear down process.
1 parent f4d73f5 commit 6f53aea

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/integration/push-jenkins-update.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,13 @@ tap.test('Posts a CI comment in the related PR when Jenkins build is named node-
117117
.reply(201)
118118

119119
t.plan(1)
120-
t.tearDown(() => commentScope.done())
121120

122121
supertest(app)
123122
.post('/node/jenkins/start')
124123
.send(fixture)
125124
.expect(201)
126125
.end((err, res) => {
126+
commentScope.done()
127127
t.equal(err, null)
128128
})
129129
})

0 commit comments

Comments
 (0)