From f4d5953516e5394914a15dba22936b10e64eff77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ot=C3=A1vio=20Silva?= <66086228+otaviosilva22@users.noreply.github.com> Date: Thu, 9 Nov 2023 11:29:17 -0300 Subject: [PATCH 1/6] Update README.md Update docker-compose example with ports usage, because is better and more cofiable than expose usage --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 83f9bdb0fb..092bee8039 100644 --- a/README.md +++ b/README.md @@ -78,8 +78,8 @@ services: - NODE_ENV=production volumes: - ./:/home/node/app - expose: - - "8081" + ports: + - "8081": "8081" command: "npm start" ``` From 390cb75062f874e0f931c3f462552ceff97fbf2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ot=C3=A1vio=20Silva?= <66086228+otaviosilva22@users.noreply.github.com> Date: Thu, 9 Nov 2023 12:41:06 -0300 Subject: [PATCH 2/6] docs: update README.md to include ports Update readme.md include both method to expose the container. --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 092bee8039..d4125f2440 100644 --- a/README.md +++ b/README.md @@ -78,7 +78,9 @@ services: - NODE_ENV=production volumes: - ./:/home/node/app - ports: + expose: + - "8081" + ports: #use if it is necessary to expose the container to the host machine - "8081": "8081" command: "npm start" ``` From f7676d2b8c17cbf25daed9cf8637abc9b4bd2e37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ot=C3=A1vio=20Silva?= <66086228+otaviosilva22@users.noreply.github.com> Date: Thu, 30 Nov 2023 15:37:26 -0300 Subject: [PATCH 3/6] Update README.md add a space Co-authored-by: Peter Dave Hello --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d4125f2440..73ce79566d 100644 --- a/README.md +++ b/README.md @@ -80,7 +80,7 @@ services: - ./:/home/node/app expose: - "8081" - ports: #use if it is necessary to expose the container to the host machine + ports: # use if it is necessary to expose the container to the host machine - "8081": "8081" command: "npm start" ``` From dbdbdaf1b7b7dfe71640a43053147fd00e21570b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ot=C3=A1vio=20Silva?= <66086228+otaviosilva22@users.noreply.github.com> Date: Fri, 1 Dec 2023 17:03:43 -0300 Subject: [PATCH 4/6] docs(README): link libc6-compat Broken libc6-compat link fix. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 73ce79566d..478e20cd3f 100644 --- a/README.md +++ b/README.md @@ -186,7 +186,7 @@ variant is usually a very safe choice. See for more discussion of the issues that might arise and some pro/con comparisons of using Alpine-based images. One common issue that may arise is a missing shared library required for use of `process.dlopen`. To add the missing shared libraries -to your image, adding the [`libc6-compat`](https://pkgs.alpinelinux.org/package/edge/main/x86/libc6-compat) +to your image, adding the [`libc6-compat`](https://pkgs.alpinelinux.org/package/v3.10/main/x86_64/libc6-compat) package in your Dockerfile is recommended: `apk add --no-cache libc6-compat` To minimize image size, it's uncommon for additional related tools From 3d07b595c0bae7d2baf70bac31b09615103c7f2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ot=C3=A1vio=20Silva?= <66086228+otaviosilva22@users.noreply.github.com> Date: Mon, 4 Dec 2023 10:14:23 -0300 Subject: [PATCH 5/6] docs(README): update link --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 478e20cd3f..73ce79566d 100644 --- a/README.md +++ b/README.md @@ -186,7 +186,7 @@ variant is usually a very safe choice. See for more discussion of the issues that might arise and some pro/con comparisons of using Alpine-based images. One common issue that may arise is a missing shared library required for use of `process.dlopen`. To add the missing shared libraries -to your image, adding the [`libc6-compat`](https://pkgs.alpinelinux.org/package/v3.10/main/x86_64/libc6-compat) +to your image, adding the [`libc6-compat`](https://pkgs.alpinelinux.org/package/edge/main/x86/libc6-compat) package in your Dockerfile is recommended: `apk add --no-cache libc6-compat` To minimize image size, it's uncommon for additional related tools From d7c2df9571c94af0d4f4cdc1257c7efb00f6e547 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ot=C3=A1vio=20Silva?= <66086228+otaviosilva22@users.noreply.github.com> Date: Mon, 4 Dec 2023 15:00:34 -0300 Subject: [PATCH 6/6] docs(README): Add ports mapping to Docker Compose example Co-authored-by: Peter Dave Hello --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 73ce79566d..b86c29ca71 100644 --- a/README.md +++ b/README.md @@ -81,7 +81,7 @@ services: expose: - "8081" ports: # use if it is necessary to expose the container to the host machine - - "8081": "8081" + - "8001:8001" command: "npm start" ```