Merge pull request #231 from nitrictech/fix/race-condition-clean

tjholm · web-flow · commit 1623eafd1dd4 · 2021-10-27T10:30:41.000+11:00
fix: check build directory exists before deletion
diff --git a/packages/common/src/task/build-function.ts b/packages/common/src/task/build-function.ts
@@ -110,7 +110,7 @@ export class BuildFunctionTask extends Task<ContainerImage> {
 			await fs.promises.unlink(`./${contextBuildDirectory}/${imageId}.toml`);
 
 			// remove build directory if empty
-			if (fs.readdirSync(contextBuildDirectory).length === 0) {
+			if (fs.existsSync(contextBuildDirectory) && fs.readdirSync(contextBuildDirectory).length === 0) {
 				await fs.promises.rmdir(contextBuildDirectory);
 			}
 		} catch (e) {

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ export class BuildFunctionTask extends Task<ContainerImage> {`
`110`	`110`	await fs.promises.unlink(`./${contextBuildDirectory}/${imageId}.toml`);
`111`	`111`
`112`	`112`	`// remove build directory if empty`
`113`		`- if (fs.readdirSync(contextBuildDirectory).length === 0) {`
	`113`	`+ if (fs.existsSync(contextBuildDirectory) && fs.readdirSync(contextBuildDirectory).length === 0) {`
`114`	`114`	`await fs.promises.rmdir(contextBuildDirectory);`
`115`	`115`	`}`
`116`	`116`	`} catch (e) {`