Comply with unused variable warnings

dandavison · dandavison · commit 0aafb5fd64c5 · 2025-07-14T11:54:41.000-04:00
AI: This commit should have tag name unused-variables and should be
force-pushed to a branch of that name as necessary.
diff --git a/pyproject.toml b/pyproject.toml
@@ -69,7 +69,6 @@ reportUnknownMemberType = "none"
 reportUnknownVariableType = "none"
 reportUnnecessaryTypeIgnoreComment = "none"
 enableTypeIgnoreComments = true
-failOnWarnings = false  # basedpyright setting
 include = ["src", "tests"]
 
 [tool.mypy]
diff --git a/tests/handler/test_handler_validates_service_handler_collection.py b/tests/handler/test_handler_validates_service_handler_collection.py
@@ -24,7 +24,7 @@ class Service:
         pass
 
     with pytest.raises(RuntimeError):
-        Handler([Service()])
+        _ = Handler([Service()])
 
 
 def test_services_are_collected():
@@ -77,4 +77,4 @@ class Service2:
         pass
 
     with pytest.raises(RuntimeError):
-        Handler([Service1(), Service2()])
+        _ = Handler([Service1(), Service2()])
diff --git a/tests/handler/test_invalid_usage.py b/tests/handler/test_invalid_usage.py
@@ -39,7 +39,11 @@ class SD:
         @service_handler(service=SD)
         class SH:
             @sync_operation(name="foo")
-            async def my_op(self, ctx: StartOperationContext, input: None) -> None: ...
+            async def my_op(
+                self, _ctx: StartOperationContext, _input: None
+            ) -> None: ...
+
+        _ = SH
 
     error_message = "Operation handlers may not override the name of an operation in the service definition"
 
@@ -56,9 +60,11 @@ class SD:
         class SH:
             @sync_operation
             async def my_op_1(
-                self, ctx: StartOperationContext, input: None
+                self, _ctx: StartOperationContext, _input: None
             ) -> None: ...
 
+        _ = SH
+
     error_message = "does not implement an operation with method name 'my_op_2'"
 
 
@@ -73,14 +79,16 @@ class SD:
         class SH:
             @sync_operation
             async def my_op_1(
-                self, ctx: StartOperationContext, input: None
+                self, _ctx: StartOperationContext, _input: None
             ) -> None: ...
 
             @sync_operation
             async def my_op_2(
-                self, ctx: StartOperationContext, input: None
+                self, _ctx: StartOperationContext, _input: None
             ) -> None: ...
 
+        _ = SH
+
     error_message = "does not match an operation method name in the service definition"
 
 
@@ -94,7 +102,11 @@ class SD:
         @service_handler(service=SD)
         class SH:
             @sync_operation
-            async def my_op(self, ctx: StartOperationContext, input: None) -> None: ...
+            async def my_op(
+                self, _ctx: StartOperationContext, _input: None
+            ) -> None: ...
+
+        _ = SH
 
     error_message = "has 0 type parameters"
 
@@ -105,9 +117,9 @@ def build():
         @service_handler
         class SH:
             @sync_operation
-            def my_op(self, ctx: StartOperationContext, input: None) -> None: ...
+            def my_op(self, _ctx: StartOperationContext, _input: None) -> None: ...
 
-        Handler([SH()])
+        _ = Handler([SH()])
 
     error_message = "you have not supplied an executor"
 
@@ -130,6 +142,8 @@ class SD:
                 output_type=None,
             )
 
+        _ = SD
+
     error_message = "Operation method name 'my_op' is not unique"
 
 
@@ -141,6 +155,8 @@ class SubclassingNoInputOutputTypeAnnotationsWithoutServiceDefinition:
             @operation_handler
             def op(self) -> OperationHandler: ...  # type: ignore
 
+        _ = SubclassingNoInputOutputTypeAnnotationsWithoutServiceDefinition
+
     error_message = r"has no input type"
 
 
diff --git a/tests/handler/test_request_routing.py b/tests/handler/test_request_routing.py
@@ -30,7 +30,7 @@ class _TestCase(_BaseTestCase):
     class UserServiceHandler:
         op: Callable[..., Any] = lambda: None
 
-        async def _op_impl(self, ctx: StartOperationContext, input: None) -> bool:
+        async def _op_impl(self, ctx: StartOperationContext, _input: None) -> bool:
             assert (service_defn := get_service_definition(self.__class__))
             assert ctx.service == service_defn.name
             op_handler_op_defn = get_operation(self.op)
diff --git a/tests/handler/test_service_handler_decorator_requirements.py b/tests/handler/test_service_handler_decorator_requirements.py
@@ -185,3 +185,5 @@ class HandlerMissingChildOp:
             def op_from_base_definition(
                 self,
             ) -> OperationHandler[int, str]: ...
+
+        _ = HandlerMissingChildOp
diff --git a/tests/handler/test_service_handler_decorator_results_in_correctly_functioning_operation_factories.py b/tests/handler/test_service_handler_decorator_results_in_correctly_functioning_operation_factories.py
@@ -71,7 +71,7 @@ class SyncOperation(_TestCase):
     class Service:
         @sync_operation
         async def sync_operation_handler(
-            self, ctx: StartOperationContext, input: int
+            self, _ctx: StartOperationContext, _input: int
         ) -> int:
             return 7
 
diff --git a/tests/handler/test_service_handler_decorator_selects_correct_service_name.py b/tests/handler/test_service_handler_decorator_selects_correct_service_name.py
@@ -87,7 +87,7 @@ def test_service_decorator_name_overrides(test_case: type[_NameOverrideTestCase]
 
 def test_name_must_not_be_empty():
     with pytest.raises(ValueError):
-        service_handler(name="")(object)
+        _ = service_handler(name="")(object)
 
 
 def test_name_and_interface_are_mutually_exclusive():
diff --git a/tests/handler/test_service_handler_decorator_validates_against_service_contract.py b/tests/handler/test_service_handler_decorator_validates_against_service_contract.py
@@ -31,7 +31,7 @@ def unrelated_method(self) -> None: ...
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: None) -> None: ...
+        async def op(self, _ctx: StartOperationContext, _input: None) -> None: ...
 
     error_message = None
 
@@ -43,7 +43,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def extra_op(self, ctx: StartOperationContext, input: None) -> None: ...
+        async def extra_op(self, _ctx: StartOperationContext, _input: None) -> None: ...
 
         def unrelated_method(self) -> None: ...
 
@@ -104,7 +104,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: None) -> str: ...
+        async def op(self, _ctx: StartOperationContext, _input: None) -> str: ...
 
     error_message = "is not compatible with the output type"
 
@@ -116,7 +116,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: str) -> str: ...
+        async def op(self, _ctx: StartOperationContext, _input: str) -> str: ...
 
     error_message = "is not compatible with the output type"
 
@@ -128,7 +128,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: str) -> None: ...
+        async def op(self, _ctx: StartOperationContext, _input: str) -> None: ...
 
     error_message = None
 
@@ -140,7 +140,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: str) -> str: ...
+        async def op(self, _ctx: StartOperationContext, _input: str) -> str: ...
 
     error_message = None
 
@@ -164,7 +164,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: X) -> X: ...
+        async def op(self, _ctx: StartOperationContext, _input: X) -> X: ...
 
     error_message = None
 
@@ -176,7 +176,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: X) -> Subclass: ...
+        async def op(self, _ctx: StartOperationContext, _input: X) -> Subclass: ...
 
     error_message = None
 
@@ -190,7 +190,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: X) -> SuperClass: ...
+        async def op(self, _ctx: StartOperationContext, _input: X) -> SuperClass: ...
 
     error_message = "is not compatible with the output type"
 
@@ -202,7 +202,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: X) -> X: ...
+        async def op(self, _ctx: StartOperationContext, _input: X) -> X: ...
 
     error_message = None
 
@@ -214,7 +214,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: SuperClass) -> X: ...
+        async def op(self, _ctx: StartOperationContext, _input: SuperClass) -> X: ...
 
     error_message = None
 
@@ -226,7 +226,7 @@ class Interface:
 
     class Impl:
         @sync_operation
-        async def op(self, ctx: StartOperationContext, input: Subclass) -> X: ...
+        async def op(self, _ctx: StartOperationContext, _input: Subclass) -> X: ...
 
     error_message = "is not compatible with the input type"
 
@@ -272,11 +272,11 @@ class Contract:
     class Service:
         @sync_operation
         async def operation_b(
-            self, ctx: StartOperationContext, input: None
+            self, _ctx: StartOperationContext, _input: None
         ) -> None: ...
 
     with pytest.raises(
         TypeError,
         match="does not match an operation method name in the service definition",
     ):
-        service_handler(service=Contract)(Service)
+        _ = service_handler(service=Contract)(Service)
diff --git a/tests/handler/test_sync_operation_handler_decorator_creates_valid_operation_handler.py b/tests/handler/test_sync_operation_handler_decorator_creates_valid_operation_handler.py
@@ -17,15 +17,15 @@ def __init__(self):
         self.mutable_container = []
 
     @sync_operation
-    def my_def_op(self, ctx: StartOperationContext, input: int) -> int:
+    def my_def_op(self, _ctx: StartOperationContext, input: int) -> int:
         """
         This is the docstring for the `my_def_op` sync operation.
         """
         self.mutable_container.append(input)
         return input + 1
 
     @sync_operation(name="foo")
-    async def my_async_def_op(self, ctx: StartOperationContext, input: int) -> int:
+    async def my_async_def_op(self, _ctx: StartOperationContext, input: int) -> int:
         """
         This is the docstring for the `my_async_def_op` sync operation.
         """
diff --git a/tests/helpers.py b/tests/helpers.py
@@ -8,10 +8,12 @@
 class DummySerializer:
     value: Any
 
-    async def serialize(self, value: Any) -> Content:
+    async def serialize(self, value: Any) -> Content:  # pyright: ignore[reportUnusedParameter]
         raise NotImplementedError
 
     async def deserialize(
-        self, content: Content, as_type: Optional[type[Any]] = None
+        self,
+        content: Content,  # pyright: ignore[reportUnusedParameter]
+        as_type: Optional[type[Any]] = None,  # pyright: ignore[reportUnusedParameter]
     ) -> Any:
         return self.value
diff --git a/tests/service_definition/test_service_decorator_selects_correct_service_name.py b/tests/service_definition/test_service_decorator_selects_correct_service_name.py
@@ -55,4 +55,4 @@ def test_interface_name_overrides(test_case: type[NameOverrideTestCase]):
 
 def test_name_must_not_be_empty():
     with pytest.raises(ValueError):
-        nexusrpc.service(name="")(object)
+        _ = nexusrpc.service(name="")(object)
diff --git a/tests/test_type_checking_sync_operation.py b/tests/test_type_checking_sync_operation.py
@@ -6,34 +6,34 @@ def _():
     @service_handler
     class TestServiceHandler:
         @sync_operation
-        def good_syncio(self, ctx: StartOperationContext, input: int) -> str:
+        def good_syncio(self, _ctx: StartOperationContext, input: int) -> str:
             return str(input)
 
         @sync_operation
-        async def good_asyncio(self, ctx: StartOperationContext, input: int) -> str:
+        async def good_asyncio(self, _ctx: StartOperationContext, input: int) -> str:
             return str(input)
 
         @sync_operation
         async def another_asyncio_1(
-            self, ctx: StartOperationContext, input: int
+            self, _ctx: StartOperationContext, input: int
         ) -> str:
-            return await self.good_asyncio(ctx, input)
+            return await self.good_asyncio(_ctx, input)
 
         @sync_operation(name="custom_name")
-        def good_syncio_with_name(self, ctx: StartOperationContext, input: str) -> int:
+        def good_syncio_with_name(self, _ctx: StartOperationContext, input: str) -> int:
             return len(input)
 
         @sync_operation(name="async_custom")
         async def good_asyncio_with_name(
-            self, ctx: StartOperationContext, input: str
+            self, _ctx: StartOperationContext, input: str
         ) -> int:
             return len(input)
 
         @sync_operation
         async def another_asyncio_2(
-            self, ctx: StartOperationContext, input: str
+            self, _ctx: StartOperationContext, input: str
         ) -> int:
-            return await self.good_asyncio_with_name(ctx, input)
+            return await self.good_asyncio_with_name(_ctx, input)
 
         # assert-type-error-pyright: 'Argument of type .+ cannot be assigned to parameter'
         # assert-type-error-mypy: "has incompatible type"
@@ -44,7 +44,7 @@ def syncio_bad_signature_1(self, x: int) -> str:
         # assert-type-error-pyright: 'Argument of type .+ cannot be assigned to parameter'
         # assert-type-error-mypy: "has incompatible type"
         @sync_operation  # type: ignore
-        def syncio_bad_signature_2(self, x: int, y: str, z: float) -> str:
+        def syncio_bad_signature_2(self, x: int, _y: str, _z: float) -> str:
             return str(x)
 
         # assert-type-error-pyright: 'Argument of type .+ cannot be assigned to parameter'
@@ -70,3 +70,5 @@ def syncio_bad_signature_with_name(self, x: int) -> str:
         @sync_operation(name="bad")  # type: ignore
         async def asyncio_bad_signature_with_name(self, x: int) -> str:
             return str(x)
+
+    _ = TestServiceHandler
diff --git a/tests/test_util.py b/tests/test_util.py
