-
Notifications
You must be signed in to change notification settings - Fork 843
Description
The app container's entrypoint currently only uses set
in a couple spots. We should test impact of enabling set -eu
globally at the top, just like in the community micro-services image here. It should be safe to use alongside the existing ones already in the AIO entrypoint.
This should prevent problems that lead to broken installations.
This originally came up because there was a forum post a few weeks I saw where rsync failed, yet the failure was not detected and the installation proceeded.
Ran across an in-the-wild environment where rsync was failing due to I/O disk errors, but initializing continued on anyhow. We should check the exit values and fail hard since it'll result in a broken installation (and may get overlooked until later depending on what files the errors occur on).
2025-01-13T15:13:04.250546270Z Initializing nextcloud 30.0.4.1 ... 2025-01-13T15:13:13.543136088Z rsync: [sender] read errors mapping "/usr/src/nextcloud/apps/text/js/pgsql-6nMyK_Wd.chunk.mjs.map": I/O error (5) [...] 2025-01-13T15:13:13.791311797Z ERROR: apps/text/js/pgsql-6nMyK_Wd.chunk.mjs.map failed verification -- update discarded. [...] 2025-01-13T15:13:18.615971825Z rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1338) [sender=3.3.0] 2025-01-13T15:13:18.903862977Z Initializing finished 2025-01-13T15:13:18.903916218Z New Nextcloud instance. 2025-01-13T15:13:18.913472340Z Installing with pgsql database 2025-01-13T15:13:18.913679471Z Starting Nextcloud installation...