Merge pull request #3299 from newrelic/remove_capistrano_and_cli_deployments

Remove `newrelic deployments` and Capistrano support

Author: hannahramadan

.github/workflows/scripts/slack_notifications/supported_gems.txt

@@ -7,7 +7,6 @@ aws-sdk-kinesis
 aws-sdk-lambda
 aws-sdk-sqs
 bunny
-capistrano
 concurrent-ruby
 curb
 dalli

.rubocop_todo.yml

@@ -22,7 +22,6 @@ Metrics/AbcSize:
   Exclude:
     - 'lib/new_relic/agent/configuration/default_source.rb'
     - infinite_tracing/test/**/*
-    - lib/new_relic/cli/commands/deployments.rb
     - test/**/*
 
 Metrics/CollectionLiteralLength:
@@ -34,7 +33,6 @@ Minitest/AssertRaisesCompoundBody:
   Exclude:
     - 'test/new_relic/agent/collector_response_code_test.rb'
     - 'test/new_relic/agent/new_relic_service_test.rb'
-    - 'test/new_relic/cli/commands/deployments_test.rb'
 
 # Offense count: 4
 Minitest/DuplicateTestRun:

README.md

@@ -77,13 +77,6 @@ For complete documentation on installing the New Relic Ruby agent, see the follo
 * [Update the agent](https://docs.newrelic.com/docs/agents/ruby-agent/installation/update-ruby-agent)
 * [Uninstall the Ruby agent](https://docs.newrelic.com/docs/agents/ruby-agent/installation/uninstall-ruby-agent)
 
-### Recording deploys
-
-The Ruby agent supports recording deployments in New Relic via a command line
-tool or Capistrano recipes. For more information on these features, see
-[our deployment documentation](http://docs.newrelic.com/docs/ruby/recording-deployments-with-the-ruby-agent)
-for more information.
-
 ## Support
 
 Should you need assistance with New Relic products, you are in good hands with several support diagnostic tools and support channels.

bin/newrelic

@@ -213,20 +213,6 @@ def self.host
           end
         end
 
-        def self.api_host
-          # only used for deployment task
-          proc do
-            api_version = if NewRelic::Agent.config[:api_key].nil? || NewRelic::Agent.config[:api_key].empty?
-              'rpm'
-            else
-              'api'
-            end
-            api_region = 'eu.' if String(NewRelic::Agent.config[:license_key]).start_with?('eu')
-
-            "#{api_version}.#{api_region}newrelic.com"
-          end
-        end
-
         def self.convert_to_regexp_list(raw_value)
           value_list = convert_to_list(raw_value)
           value_list.map do |value|
@@ -422,14 +408,6 @@ def self.enforce_fallback(allowed_values: nil, fallback: nil)
           :allowed_from_server => true,
           :description => 'For agent versions 3.5.0 or higher, [set your Apdex T via the New Relic UI](/docs/apm/new-relic-apm/apdex/changing-your-apdex-settings).'
         },
-        :api_key => {
-          :default => '',
-          :public => true,
-          :type => String,
-          :allowed_from_server => false,
-          :exclude_from_reported_settings => true,
-          :description => '# DEPRECATED: The `api_key` config setting is now deprecated. Its only use was for the `newrelic deployments` command, which is being removed in agent version 10.0.0.'
-        },
         :backport_fast_active_record_connection_lookup => {
           :default => false,
           :public => true,
@@ -2326,20 +2304,6 @@ def self.enforce_fallback(allowed_values: nil, fallback: nil)
           :allowed_from_server => true,
           :description => 'If true, attempt to keep the TCP connection to the collector alive between harvests.'
         },
-        :api_host => {
-          :default => DefaultSource.api_host,
-          :public => false,
-          :type => String,
-          :allowed_from_server => false,
-          :description => 'API host for New Relic.'
-        },
-        :api_port => {
-          :default => value_of(:port),
-          :public => false,
-          :type => Integer,
-          :allowed_from_server => false,
-          :description => 'Port for the New Relic API host.'
-        },
         :application_id => {
           :default => '',
           :public => false,

lib/new_relic/agent/configuration/default_source.rb

@@ -4,9 +4,8 @@
 
 require 'optparse'
 
-# Run the command given by the first argument.  Right
-# now all we have is deployments. We hope to have other
-# kinds of events here later.
+# Run the command given by the first argument.
+# Commands can be found in the commands/ directory.
 $LOAD_PATH << "#{File.dirname(__FILE__)}/.."
 module NewRelic
   module Cli
@@ -73,8 +72,6 @@ def self.run
         end
         extra = options.order!
         command = extra.shift
-        # just make it a little easier on them
-        command = 'deployments' if command.include?('deploy')
         if command.nil?
           STDERR.puts options
         elsif !@command_names.include?(command)

lib/new_relic/cli/command.rb

@@ -15,12 +15,6 @@ def server
         @remote_server ||= server_from_host(nil)
       end
 
-      # the server we should contact for api requests, like uploading
-      # deployments and the like
-      def api_server
-        @api_server ||= NewRelic::Control::Server.new(Agent.config[:api_host], Agent.config[:api_port])
-      end
-
       def server_from_host(hostname = nil)
         NewRelic::Control::Server.new(hostname || Agent.config[:host], Agent.config[:port])
       end