Process: History and Config-func #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emil14
commented
Dec 3, 2023
examples/logging/main.go
Outdated
| } | ||
|
|
||
| func Logger(input, output agency.Message, cfg *agency.OperationConfig) { | ||
| func Logger(input, output agency.Message, cfg *agency.OperationConfig, _ uint) { |
Contributor
Author
There was a problem hiding this comment.
- Pass history here?
- Combine all arguments into single structure?
P.S. - last parameter is step-index, interface of the interceptor was changed and interceptor was renamed to observer
emil14
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem that process step can't access results of previous steps, except the one previous step. For example, in a 3-step process it's not possible to get result of the first step inside third step.
It solves this by introducing 2 new abstractions - history and config func. History it's just a slice of intermediate results of steps, that Process maintains while executing steps. Config function is an "interceptor" API that allows to modify config of the operation (step) before executing it.
These 2 abstractions combined allow to preconfigure any step and inject data form history into its config. For example, in our case with 3-step process it allows to access result of the first step and e.g. inject it into the prompt for the third step.