Merge pull request #3992 from neos/bugfix/speedup-copy-node-by-removing-recursive-node-fetching-in-response

BUGFIX: Speed up node tree copy actions 9.0 port of #3984

Author: mhsdesign

Classes/Domain/Model/Changes/AbstractStructuralChange.php

@@ -125,7 +125,6 @@ protected function finish(Node $node)
     {
         $updateNodeInfo = new UpdateNodeInfo();
         $updateNodeInfo->setNode($node);
-        $updateNodeInfo->recursive();
         $this->feedbackCollection->add($updateNodeInfo);
 
         $parentNode = $this->contentRepositoryRegistry->subgraphForNode($node)

Classes/Domain/Model/Feedback/Operations/UpdateNodeInfo.php

@@ -41,8 +41,6 @@ class UpdateNodeInfo extends AbstractFeedback
      */
     protected $contentRepositoryRegistry;
 
-    protected bool $isRecursive = false;
-
     protected ?string $baseNodeType = null;
 
     public function setBaseNodeType(?string $baseNodeType): void
@@ -60,14 +58,6 @@ public function setNode(Node $node): void
         $this->node = $node;
     }
 
-    /**
-     * Update node infos recursively
-     */
-    public function recursive(): void
-    {
-        $this->isRecursive = true;
-    }
-
     public function getNode(): Node
     {
         return $this->node;
@@ -103,7 +93,7 @@ public function isSimilarTo(FeedbackInterface $feedback): bool
     public function serializePayload(ControllerContext $controllerContext): array
     {
         return [
-            'byContextPath' => $this->serializeNodeRecursively($this->node, $controllerContext->getRequest())
+            'byContextPath' => $this->serializeNode($this->node, $controllerContext->getRequest())
         ];
     }
 
@@ -112,25 +102,13 @@ public function serializePayload(ControllerContext $controllerContext): array
      *
      * @return array<string,?array<string,mixed>>
      */
-    private function serializeNodeRecursively(Node $node, ActionRequest $actionRequest): array
+    private function serializeNode(Node $node, ActionRequest $actionRequest): array
     {
-        $contentRepository = $this->contentRepositoryRegistry->get($node->contentRepositoryId);
-
-        $result = [
-            NodeAddress::fromNode($node)->toJson()
-            => $this->nodeInfoHelper->renderNodeWithPropertiesAndChildrenInformation(
+        return [
+            NodeAddress::fromNode($node)->toJson() => $this->nodeInfoHelper->renderNodeWithPropertiesAndChildrenInformation(
                 $node,
                 $actionRequest
             )
         ];
-
-        if ($this->isRecursive === true) {
-            $subgraph = $this->contentRepositoryRegistry->subgraphForNode($node);
-            foreach ($subgraph->findChildNodes($node->aggregateId, FindChildNodesFilter::create()) as $childNode) {
-                $result = array_merge($result, $this->serializeNodeRecursively($childNode, $actionRequest));
-            }
-        }
-
-        return $result;
     }
 }