OKX request sign error

[S3toGreen]

Bug Report

okx request sign error

the original _sign function in nautilus_trader/adapters/okx/http/client.py

    def _sign(self, timestamp: str, method: str, url_path: str, body: str) -> str:
        if body == "{}" or body == "None":
            body = ""
        message = str(timestamp) + method.upper() + url_path + body
        digest = hmac_signature(self._api_secret, message).encode()
        return base64.b64encode(digest).decode()

and _login function in nautilus_trader/adapters/okx/websocket/client.py

    async def _login(self):
        if self._api_secret is None:
            raise ValueError("`api_secret` was `None` for private websocket")

        timestamp = int(self._clock.timestamp())
        message = str(timestamp) + "GET/users/self/verify"
        digest = bytes.fromhex(hmac_signature(self._api_secret, message))
        sign = base64.b64encode(digest).decode()
        payload = {
            "op": "login",
            "args": [
                {
                    "apiKey": self._api_key,
                    "passphrase": self._passphrase,
                    "timestamp": str(timestamp),
                    "sign": sign,
                },
            ],
        }
        await self._send(payload)

result is not expected and get rejected from exchange.
cast to byte string solve the error in both websocket and http

        digest = bytes.fromhex(hmac_signature(self._api_secret, message))

[cjdsellers]

Hi @S3toGreen

Thanks for the report.

The OKX integration is still in building status, and so potentially not in a working state.

I'll make sure to apply your suggested fix though and credit you in the release notes.

[cjdsellers]

Now fixed from 86b0c0c.