Standardize test attributes to rstest

Author: cjdsellers

crates/adapters/coinbase_intx/src/fix/messages.rs

@@ -328,10 +328,11 @@ impl FixMessage {
 #[cfg(test)]
 mod tests {
     use chrono::TimeZone;
+    use rstest::rstest;
 
     use super::*;
 
-    #[test]
+    #[rstest]
     fn test_fix_message_to_bytes_simple() {
         let timestamp = Utc.with_ymd_and_hms(2025, 3, 22, 12, 34, 56).unwrap();
         let mut msg = FixMessage::new(fix_message_type::LOGON, 1, "SENDER", "TARGET", &timestamp);
@@ -347,7 +348,7 @@ mod tests {
         assert_eq!(message, expected);
     }
 
-    #[test]
+    #[rstest]
     fn test_fix_message_to_bytes_complete_logon() {
         let timestamp = Utc.with_ymd_and_hms(2025, 3, 22, 12, 34, 56).unwrap();
         let msg = FixMessage::create_logon(

crates/analysis/src/analyzer.rs

@@ -404,6 +404,7 @@ mod tests {
         instruments::InstrumentAny,
         types::{AccountBalance, Money, Price, Quantity},
     };
+    use rstest::rstest;
 
     use super::*;
 
@@ -581,7 +582,7 @@ mod tests {
         }
     }
 
-    #[test]
+    #[rstest]
     fn test_register_and_deregister_statistics() {
         let mut analyzer = PortfolioAnalyzer::new();
         let stat = Arc::new(MockStatistic::new("test_stat"));
@@ -603,7 +604,7 @@ mod tests {
         assert!(analyzer.statistics.is_empty());
     }
 
-    #[test]
+    #[rstest]
     fn test_calculate_total_pnl() {
         let mut analyzer = PortfolioAnalyzer::new();
         let currency = Currency::USD();
@@ -634,7 +635,7 @@ mod tests {
         assert_eq!(result, 600.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_calculate_total_pnl_percentage() {
         let mut analyzer = PortfolioAnalyzer::new();
         let currency = Currency::USD();
@@ -667,7 +668,7 @@ mod tests {
         assert_eq!(result, 100.0); // (2000 - 1000) / 1000 * 100
     }
 
-    #[test]
+    #[rstest]
     fn test_add_positions_and_returns() {
         let mut analyzer = PortfolioAnalyzer::new();
         let currency = Currency::USD();
@@ -691,7 +692,7 @@ mod tests {
         assert_eq!(*returns.values().next().unwrap(), 0.30000000000000004);
     }
 
-    #[test]
+    #[rstest]
     fn test_performance_stats_calculation() {
         let mut analyzer = PortfolioAnalyzer::new();
         let currency = Currency::USD();
@@ -734,7 +735,7 @@ mod tests {
         assert!(general_stats.contains_key("test_stat"));
     }
 
-    #[test]
+    #[rstest]
     fn test_formatted_output() {
         let mut analyzer = PortfolioAnalyzer::new();
         let currency = Currency::USD();
@@ -775,7 +776,7 @@ mod tests {
         assert!(general_formatted.iter().all(|s| s.contains(':')));
     }
 
-    #[test]
+    #[rstest]
     fn test_reset() {
         let mut analyzer = PortfolioAnalyzer::new();
         let currency = Currency::USD();

crates/analysis/src/statistics/expectancy.rs

@@ -56,17 +56,19 @@ impl PortfolioStatistic for Expectancy {
 
 #[cfg(test)]
 mod tests {
+    use rstest::rstest;
+
     use super::*;
 
-    #[test]
+    #[rstest]
     fn test_empty_pnl_list() {
         let expectancy = Expectancy {};
         let result = expectancy.calculate_from_realized_pnls(&[]);
         assert!(result.is_some());
         assert_eq!(result.unwrap(), 0.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_all_winners() {
         let expectancy = Expectancy {};
         let pnls = vec![10.0, 20.0, 30.0];
@@ -78,7 +80,7 @@ mod tests {
         assert_eq!(result.unwrap(), 20.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_all_losers() {
         let expectancy = Expectancy {};
         let pnls = vec![-10.0, -20.0, -30.0];
@@ -90,7 +92,7 @@ mod tests {
         assert_eq!(result.unwrap(), -20.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_mixed_pnls() {
         let expectancy = Expectancy {};
         let pnls = vec![10.0, -5.0, 15.0, -10.0];
@@ -106,7 +108,7 @@ mod tests {
         assert_eq!(result.unwrap(), 2.5);
     }
 
-    #[test]
+    #[rstest]
     fn test_single_trade() {
         let expectancy = Expectancy {};
         let pnls = vec![10.0];
@@ -118,7 +120,7 @@ mod tests {
         assert_eq!(result.unwrap(), 10.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_name() {
         let expectancy = Expectancy {};
         assert_eq!(expectancy.name(), "Expectancy");

crates/analysis/src/statistics/long_ratio.rs

@@ -74,6 +74,7 @@ mod tests {
         },
         types::{Currency, Quantity},
     };
+    use rstest::rstest;
 
     use super::*;
 
@@ -115,14 +116,14 @@ mod tests {
         }
     }
 
-    #[test]
+    #[rstest]
     fn test_empty_positions() {
         let long_ratio = LongRatio::new(None);
         let result = long_ratio.calculate_from_positions(&[]);
         assert!(result.is_none());
     }
 
-    #[test]
+    #[rstest]
     fn test_all_long_positions() {
         let long_ratio = LongRatio::new(None);
         let positions = vec![
@@ -136,7 +137,7 @@ mod tests {
         assert_eq!(result.unwrap(), 1.00);
     }
 
-    #[test]
+    #[rstest]
     fn test_all_short_positions() {
         let long_ratio = LongRatio::new(None);
         let positions = vec![
@@ -150,7 +151,7 @@ mod tests {
         assert_eq!(result.unwrap(), 0.00);
     }
 
-    #[test]
+    #[rstest]
     fn test_mixed_positions() {
         let long_ratio = LongRatio::new(None);
         let positions = vec![
@@ -165,7 +166,7 @@ mod tests {
         assert_eq!(result.unwrap(), 0.50);
     }
 
-    #[test]
+    #[rstest]
     fn test_custom_precision() {
         let long_ratio = LongRatio::new(Some(3));
         let positions = vec![
@@ -179,7 +180,7 @@ mod tests {
         assert_eq!(result.unwrap(), 0.667);
     }
 
-    #[test]
+    #[rstest]
     fn test_single_position_long() {
         let long_ratio = LongRatio::new(None);
         let positions = vec![create_test_position(OrderSide::Buy)];
@@ -189,7 +190,7 @@ mod tests {
         assert_eq!(result.unwrap(), 1.00);
     }
 
-    #[test]
+    #[rstest]
     fn test_single_position_short() {
         let long_ratio = LongRatio::new(None);
         let positions = vec![create_test_position(OrderSide::Sell)];
@@ -199,7 +200,7 @@ mod tests {
         assert_eq!(result.unwrap(), 0.00);
     }
 
-    #[test]
+    #[rstest]
     fn test_zero_precision() {
         let long_ratio = LongRatio::new(Some(0));
         let positions = vec![
@@ -213,7 +214,7 @@ mod tests {
         assert_eq!(result.unwrap(), 1.00);
     }
 
-    #[test]
+    #[rstest]
     fn test_name() {
         let long_ratio = LongRatio::new(None);
         assert_eq!(long_ratio.name(), "LongRatio");

crates/analysis/src/statistics/loser_avg.rs

@@ -52,17 +52,19 @@ impl PortfolioStatistic for AvgLoser {
 
 #[cfg(test)]
 mod tests {
+    use rstest::rstest;
+
     use super::*;
 
-    #[test]
+    #[rstest]
     fn test_empty_pnls() {
         let avg_loser = AvgLoser {};
         let result = avg_loser.calculate_from_realized_pnls(&[]);
         assert!(result.is_some());
         assert_eq!(result.unwrap(), 0.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_no_losers() {
         let avg_loser = AvgLoser {};
         let pnls = vec![10.0, 20.0, 30.0];
@@ -71,7 +73,7 @@ mod tests {
         assert_eq!(result.unwrap(), 0.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_only_losers() {
         let avg_loser = AvgLoser {};
         let pnls = vec![-10.0, -20.0, -30.0];
@@ -80,7 +82,7 @@ mod tests {
         assert_eq!(result.unwrap(), -20.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_mixed_pnls() {
         let avg_loser = AvgLoser {};
         let pnls = vec![10.0, -20.0, 30.0, -40.0];
@@ -89,7 +91,7 @@ mod tests {
         assert_eq!(result.unwrap(), -30.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_zero_included() {
         let avg_loser = AvgLoser {};
         let pnls = vec![10.0, 0.0, -20.0, -30.0];
@@ -99,7 +101,7 @@ mod tests {
         assert_eq!(result.unwrap(), -16.666666666666668);
     }
 
-    #[test]
+    #[rstest]
     fn test_single_loser() {
         let avg_loser = AvgLoser {};
         let pnls = vec![-10.0];
@@ -108,7 +110,7 @@ mod tests {
         assert_eq!(result.unwrap(), -10.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_name() {
         let avg_loser = AvgLoser {};
         assert_eq!(avg_loser.name(), "AvgLoser");

crates/analysis/src/statistics/loser_max.rs

@@ -45,25 +45,27 @@ impl PortfolioStatistic for MaxLoser {
 
 #[cfg(test)]
 mod tests {
+    use rstest::rstest;
+
     use super::*;
 
-    #[test]
+    #[rstest]
     fn test_empty_pnls() {
         let max_loser = MaxLoser {};
         let result = max_loser.calculate_from_realized_pnls(&[]);
         assert!(result.is_some());
         assert_eq!(result.unwrap(), 0.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_all_positive() {
         let max_loser = MaxLoser {};
         let pnls = vec![10.0, 20.0, 30.0];
         let result = max_loser.calculate_from_realized_pnls(&pnls);
         assert!(result.is_none());
     }
 
-    #[test]
+    #[rstest]
     fn test_all_negative() {
         let max_loser = MaxLoser {};
         let pnls = vec![-10.0, -20.0, -30.0];
@@ -72,7 +74,7 @@ mod tests {
         assert_eq!(result.unwrap(), -30.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_mixed_pnls() {
         let max_loser = MaxLoser {};
         let pnls = vec![10.0, -20.0, 30.0, -40.0];
@@ -81,7 +83,7 @@ mod tests {
         assert_eq!(result.unwrap(), -40.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_with_zero() {
         let max_loser = MaxLoser {};
         let pnls = vec![10.0, 0.0, -20.0, -30.0];
@@ -90,7 +92,7 @@ mod tests {
         assert_eq!(result.unwrap(), -30.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_single_value() {
         let max_loser = MaxLoser {};
         let pnls = vec![-10.0];
@@ -99,7 +101,7 @@ mod tests {
         assert_eq!(result.unwrap(), -10.0);
     }
 
-    #[test]
+    #[rstest]
     fn test_name() {
         let max_loser = MaxLoser {};
         assert_eq!(max_loser.name(), "MaxLoser");