review

Author: mstgnz

handler/aws.go

@@ -3,7 +3,6 @@ package handler
 import (
 	"io"
 	"path/filepath"
-	"strconv"
 	"time"
 
 	"github.com/gofiber/fiber/v2"
@@ -66,17 +65,17 @@ func (a awsHandler) BucketExists(c *fiber.Ctx) error {
 	bucketName := c.Params("bucket")
 	exists := a.awsService.BucketExists(bucketName)
 	if !exists {
-		return service.Response(c, fiber.StatusNotFound, false, "not found", strconv.FormatBool(exists))
+		return service.Response(c, fiber.StatusNotFound, false, "bucket not found", nil)
 	}
-	return service.Response(c, fiber.StatusFound, true, "found", strconv.FormatBool(exists))
+	return service.Response(c, fiber.StatusOK, true, "bucket exists", nil)
 }
 
 func (a awsHandler) BucketList(c *fiber.Ctx) error {
 	buckets, err := a.awsService.ListBuckets()
 	if err != nil {
 		return service.Response(c, fiber.StatusOK, false, err.Error(), buckets)
 	}
-	return service.Response(c, fiber.StatusOK, true, "buckets", buckets)
+	return service.Response(c, fiber.StatusOK, true, "buckets listed", buckets)
 }
 
 func (a awsHandler) GlacierVaultList(c *fiber.Ctx) error {

handler/health.go

@@ -41,7 +41,7 @@ func (h *HealthChecker) HealthCheck(c *fiber.Ctx) error {
 		statusCode = fiber.StatusServiceUnavailable
 	}
 
-	status := map[string]any{
+	data := map[string]any{
 		"status": overallStatus,
 		"services": map[string]any{
 			"minio": minioHealth,
@@ -51,7 +51,7 @@ func (h *HealthChecker) HealthCheck(c *fiber.Ctx) error {
 		"timestamp": time.Now().UTC(),
 	}
 
-	return service.Response(c, statusCode, true, "Health check", status)
+	return service.Response(c, statusCode, true, "Health check", data)
 }
 
 func (h *HealthChecker) checkMinioHealth(ctx context.Context) string {

handler/minio.go

@@ -2,7 +2,6 @@ package handler
 
 import (
 	"context"
-	"strconv"
 
 	"github.com/gofiber/fiber/v2"
 	"github.com/minio/minio-go/v7"
@@ -29,16 +28,19 @@ func (m minioHandler) BucketList(c *fiber.Ctx) error {
 	if err != nil {
 		return service.Response(c, fiber.StatusOK, false, err.Error(), buckets)
 	}
-	return service.Response(c, fiber.StatusOK, true, "buckets", buckets)
+	return service.Response(c, fiber.StatusOK, true, "buckets listed", buckets)
 }
 
 func (m minioHandler) BucketExists(c *fiber.Ctx) error {
 	bucketName := c.Params("bucket")
 	exists, err := m.minioClient.BucketExists(context.Background(), bucketName)
 	if err != nil {
-		return service.Response(c, fiber.StatusNotFound, false, err.Error(), strconv.FormatBool(exists))
+		return service.Response(c, fiber.StatusNotFound, false, err.Error(), nil)
 	}
-	return service.Response(c, fiber.StatusFound, true, "success", strconv.FormatBool(exists))
+	if !exists {
+		return service.Response(c, fiber.StatusNotFound, false, "bucket not found", nil)
+	}
+	return service.Response(c, fiber.StatusOK, true, "bucket exists", nil)
 }
 
 func (m minioHandler) CreateBucket(c *fiber.Ctx) error {
@@ -47,7 +49,7 @@ func (m minioHandler) CreateBucket(c *fiber.Ctx) error {
 	if err != nil {
 		return service.Response(c, fiber.StatusOK, false, err.Error(), bucketName)
 	}
-	return service.Response(c, fiber.StatusCreated, true, "success", bucketName)
+	return service.Response(c, fiber.StatusCreated, true, "bucket created", bucketName)
 }
 
 func (m minioHandler) RemoveBucket(c *fiber.Ctx) error {
@@ -56,5 +58,5 @@ func (m minioHandler) RemoveBucket(c *fiber.Ctx) error {
 	if err != nil {
 		return service.Response(c, fiber.StatusOK, false, err.Error(), bucketName)
 	}
-	return service.Response(c, fiber.StatusOK, true, "success", bucketName)
+	return service.Response(c, fiber.StatusOK, true, "bucket deleted", bucketName)
 }

public/scalar.yaml

@@ -1182,4 +1182,3 @@ paths:
                   downloadType: "minio"
         '404':
           description: Download job not found
-