fix: force dynamic pools page and improved error handling

Author: chambaz

src/app/api/search/arena/pools/all/route.ts

@@ -3,28 +3,38 @@ import { ArenaPool } from "@/lib/types";
 
 export async function GET() {
   try {
+    if (!process.env.MARGINFI_API_URL || !process.env.MARGINFI_API_KEY) {
+      console.error("Missing required environment variables");
+      return NextResponse.json(
+        { error: "API configuration error" },
+        { status: 500 },
+      );
+    }
+
     const arenaPoolsRes = await fetch(
-      process.env.MARGINFI_API_URL! + "/arena/pools",
+      process.env.MARGINFI_API_URL + "/arena/pools",
       {
         headers: {
-          "x-api-key": process.env.MARGINFI_API_KEY!,
+          "x-api-key": process.env.MARGINFI_API_KEY,
         },
       },
     );
-    const arenaPoolsData = (await arenaPoolsRes.json()) as {
-      data: ArenaPool[];
-    };
-    const arenaPools = arenaPoolsData.data.filter((pool) => pool.group);
 
-    if (!arenaPoolsRes.ok || !arenaPools) {
+    if (!arenaPoolsRes.ok) {
+      console.error("Failed to fetch arena pools:", arenaPoolsRes.statusText);
       return NextResponse.json({ banks: [] }, { status: 200 });
     }
 
+    const arenaPoolsData = (await arenaPoolsRes.json()) as {
+      data: ArenaPool[];
+    };
+
+    const arenaPools = arenaPoolsData.data?.filter((pool) => pool.group) ?? [];
     const banks = arenaPools.filter((pool) => pool.base_bank.mint.address);
 
     return NextResponse.json({ banks }, { status: 200 });
   } catch (error) {
-    console.error(error);
+    console.error("Error fetching arena pools:", error);
     return NextResponse.json(
       { error: "Internal Server Error" },
       { status: 500 },

src/app/arena/pools/page.tsx

@@ -4,25 +4,42 @@ import { Suspense } from "react";
 import { SearchArenaPools } from "@/components/search-arena-pools";
 import { Loader } from "@/components/ui/loader";
 import { ArenaPool } from "@/lib/types";
+
 export const metadata: Metadata = {
   title: "Arena Search - Banks",
   description: "Search for arena banks",
 };
 
+export const dynamic = "force-dynamic";
+export const revalidate = 0;
+
 async function getBanks() {
-  const arenaPoolsRes = await fetch(
-    `${process.env.NEXT_PUBLIC_BASE_URL}/api/search/arena/pools/all`,
-  );
-  const arenaPoolsData = await arenaPoolsRes.json();
-  const arenaPools: ArenaPool[] = arenaPoolsData.banks.filter(
-    (pool: ArenaPool) => pool.group,
-  );
+  try {
+    const baseUrl = process.env.NEXT_PUBLIC_BASE_URL || "http://localhost:3000";
+    const arenaPoolsRes = await fetch(`${baseUrl}/api/search/arena/pools/all`, {
+      next: { revalidate: 0 },
+    });
+
+    if (!arenaPoolsRes.ok) {
+      console.error("Failed to fetch banks:", arenaPoolsRes.statusText);
+      return [];
+    }
 
-  if (!arenaPoolsRes.ok || !arenaPools) {
+    const arenaPoolsData = await arenaPoolsRes.json();
+
+    if (!arenaPoolsData.banks) {
+      return [];
+    }
+
+    const arenaPools: ArenaPool[] = arenaPoolsData.banks.filter(
+      (pool: ArenaPool) => pool.group,
+    );
+
+    return arenaPools.filter((pool) => pool.base_bank.mint.address);
+  } catch (error) {
+    console.error("Error fetching banks:", error);
     return [];
   }
-
-  return arenaPools.filter((pool) => pool.base_bank.mint.address);
 }
 
 export default async function BanksSearchPage() {