Skip to content

Commit 7f4add8

Browse files
na-na-hiDudemanguy
authored andcommitted
options: disable --input-ime by default
Enabling IME by default can cause problems when the player is expecting keybinds and not text input. Windows IME implementation mitigates this by switching IME to alphanumeric mode, but this is impossible on Wayland with the text input protocol. Disable it by default and add a note to recommend enabling IME only on demand, like console.lua.
1 parent 052870b commit 7f4add8

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

DOCS/interface-changes/input.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
add `--input-ime` to enable or disable the IME on supported VOs (Windows, Wayland)
2+
disable IME by default; set `--input-ime=yes` to enable it on demand

DOCS/man/options.rst

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4496,14 +4496,24 @@ Input
44964496

44974497
``--input-ime=<yes|no>``
44984498
Enable keyboard input via an active input method (IME) connected to the VO.
4499-
(default: yes). The input popup window, if there is any, is always
4499+
(default: no). The input popup window, if there is any, is always
45004500
positioned at the top left of the window. Whether pre-edit text is drawn
45014501
depends on the platform. You may need to configure your IME to display the
45024502
pre-edit inside of the input popup window if you cannot read the pre-edit
45034503
text in the mpv window.
45044504

45054505
Wayland and Windows only. This option is not applicable to terminal input.
45064506

4507+
.. note::
4508+
4509+
Enabling IME can cause problems with key bindings, because mpv cannot
4510+
detect any key presses when they go into the IME pre-edit area.
4511+
It is recommended to enable IME on demand only for the duration
4512+
while text input is expected.
4513+
4514+
The builtin console and input selector enable IME for the duration
4515+
of accepting text input.
4516+
45074517
OSD
45084518
---
45094519

options/options.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,6 @@ const struct m_sub_options vo_sub_opts = {
261261
.keepaspect = true,
262262
.keepaspect_window = true,
263263
.native_fs = true,
264-
.input_ime = true,
265264
.taskbar_progress = true,
266265
.show_in_taskbar = true,
267266
.border = true,

0 commit comments

Comments
 (0)