Merge pull request #246 from bugout-dev/duplication-check

Add duplicates check.

Author: Andrei-Dolgolev

api/engineapi/actions.py

@@ -1,4 +1,5 @@
 from datetime import datetime
+from collections import Counter
 from typing import List, Any, Optional, Dict
 import uuid
 import logging
@@ -44,6 +45,13 @@ class DublicateClaimantError(Exception):
     pass
 
 
+class DuplicateLeaderboardAddressError(Exception):
+    def __init__(self, message, duplicates):
+        super(DuplicateLeaderboardAddressError, self).__init__(message)
+        self.message = message
+        self.duplicates = duplicates
+
+
 BATCH_SIGNATURE_PAGE_SIZE = 500
 
 logger = logging.getLogger(__name__)
@@ -1150,7 +1158,15 @@ def add_scores(
 
     normalizer_fn = Web3.toChecksumAddress
     if not normalize_addresses:
-        normalizer_fn = lambda x: x
+        normalizer_fn = lambda x: x  # type: ignore
+
+    addresses = [score.address for score in scores]
+
+    if len(addresses) != len(set(addresses)):
+
+        duplicates = [key for key, value in Counter(addresses).items() if value > 1]
+
+        raise DuplicateLeaderboardAddressError("Dublicated addresses", duplicates)
 
     if overwrite:
         db_session.query(LeaderboardScores).filter(

api/engineapi/routes/leaderboard.py

@@ -218,13 +218,21 @@ async def leaderboard(
         raise EngineHTTPException(
             status_code=403, detail="You don't have access to this leaderboard."
         )
-
-    leaderboard_points = actions.add_scores(
-        db_session=db_session,
-        leaderboard_id=leaderboard_id,
-        scores=scores,
-        overwrite=overwrite,
-        normalize_addresses=normalize_addresses,
-    )
+    try:
+        leaderboard_points = actions.add_scores(
+            db_session=db_session,
+            leaderboard_id=leaderboard_id,
+            scores=scores,
+            overwrite=overwrite,
+            normalize_addresses=normalize_addresses,
+        )
+    except actions.DuplicateLeaderboardAddressError as e:
+        raise EngineHTTPException(
+            status_code=409,
+            detail=f"Duplicates in push to database is disallowed.\n List of duplicates:{e.duplicates}.\n Please handle duplicates manualy.",
+        )
+    except Exception as e:
+        logger.error(f"Score update failed with error: {e}")
+        raise EngineHTTPException(status_code=500, detail="Score update failed.")
 
     return leaderboard_points