fix: make inspect for ObjectId work #412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
Object.defineProperty()
calls did not work becausethey did not specify a property descriptor, and even if they had
worked, the signatures of
.inspect()
and.toString()
wouldhave mismatched, and even if they weren’t, the result would not
have been very useful as debugging output, because it only returned
the raw hex content of the
ObjectId
and not even e.g. the factthat this object is an
ObjectId
.I’m happy with any other solution, but this particular one would
make my life a tiny bit easier :)
Description
Make the
inspect
and[util.inspect.custom]
methods onObjectId
work.Not sure if I should open a JIRA ticket for this, but happy to do so if it helps :)