fix --ui issues, closes #3746 #3756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
added
type: bug
4 tasks
plroebuck
approved these changes
Feb 21, 2019
Contributor
plroebuck
left a comment
plroebuck
left a comment
There was a problem hiding this comment.
Code looks fine, though I really don't like your variable name factory (since it isn't one). Maybe _interface (since we can't use the word itself).
move all ui-related tests into `test/integration/options/ui.spec.js`
boneskull
force-pushed
the
boneskull/issue/3746
branch
from
138e69f to
be7da93
Compare
Member
Author
|
yeah, |
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also move all ui-related tests into
test/integration/options/ui.spec.js