[Bug] Fixed MiniExcel.SaveAsByTemplate error when value is List<Dictionary<string, object>> #413

Author: shps951023

docs/README.md

@@ -22,6 +22,12 @@
 
 ---
 
+### 1.26.7
+- [OPT] Reduce memory allocation when using MemoryStream #427 (via @cupsos)
+- [OPT] Add System.Memory pacakge #427 (via @cupsos)
+- [OPT] Reduce memory allocation in GetImageFormat() #427 (via @cupsos)
+- [Bug] Fixed MiniExcel.SaveAsByTemplate error when value is List<Dictionary<string, object>> #413 (via @shps951023)
+
 ### 1.26.6
 - [OPT] Template save performance #425 (via @lileyzhao)
 

docs/README.zh-CN.md

@@ -25,6 +25,12 @@
 
 ---
 
+### 1.26.7
+- [OPT] 减少 memory allocation 使用 MemoryStream #427 (via @cupsos)
+- [OPT] 添加 System.Memory pacakge #427 (via @cupsos)
+- [OPT] 减少 memory allocation in GetImageFormat() #427 (via @cupsos)
+- [Bug] 修正 MiniExcel.SaveAsByTemplate value 为 List<Dictionary<string, object>> 异常错误 #413 (via @shps951023)
+
 ### 1.26.6
 - [OPT] Template save performance #425 (via @lileyzhao)
 

docs/README.zh-Hant.md

@@ -24,6 +24,13 @@
 
 ---
 
+
+### 1.26.7
+- [OPT] 減少 memory allocation 使用 MemoryStream #427 (via @cupsos)
+- [OPT] 添加 System.Memory pacakge #427 (via @cupsos)
+- [OPT] 減少 memory allocation in GetImageFormat() #427 (via @cupsos)
+- [Bug] 修正 MiniExcel.SaveAsByTemplate value 為 List<Dictionary<string, object>> 異常錯誤 #413 (via @shps951023)
+
 ### 1.26.6
 - [OPT] Template save performance #425 (via @lileyzhao)
 

samples/xlsx/TestIssue413.xlsx

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
 		<TargetFrameworks>net45;netstandard2.0;net5.0</TargetFrameworks>
-		<Version>1.26.6</Version>
+		<Version>1.26.7</Version>
 	</PropertyGroup>
 	<PropertyGroup>
 		<AssemblyName>MiniExcel</AssemblyName>

src/MiniExcel/MiniExcelLibs.csproj

@@ -389,10 +389,20 @@ private void WriteSheetXml(Stream stream, XmlDocument doc, XmlNode sheetData)
         private static string ConvertToDateTimeString(KeyValuePair<string, PropInfo> propInfo, object cellValue)
         {
             string cellValueStr;
+
+
             //TODO:c.SetAttribute("t", "d"); and custom format
-            var format = propInfo.Value.PropertyInfo.GetAttributeValue((ExcelFormatAttribute x) => x.Format)
-                         ?? propInfo.Value.PropertyInfo.GetAttributeValue((ExcelColumnAttribute x) => x.Format)
-                         ?? "yyyy-MM-dd HH:mm:ss";
+            var format = string.Empty;
+            if (propInfo.Value.PropertyInfo == null)
+            {
+                format = "yyyy-MM-dd HH:mm:ss";
+            }
+            else
+            {
+                format = propInfo.Value.PropertyInfo.GetAttributeValue((ExcelFormatAttribute x) => x.Format)
+                             ?? propInfo.Value.PropertyInfo.GetAttributeValue((ExcelColumnAttribute x) => x.Format)
+                             ?? "yyyy-MM-dd HH:mm:ss";
+            }
 
             cellValueStr = (cellValue as DateTime?)?.ToString(format);
             return cellValueStr;

src/MiniExcel/OpenXml/ExcelOpenXmlTemplate.Impl.cs

@@ -34,6 +34,27 @@ public MiniExcelIssueTests(ITestOutputHelper output)
             this.output = output;
         }
 
+        /// <summary>
+        /// [ · Issue #413 · MiniExcel/MiniExcel]
+        /// (https://github.com/MiniExcel/MiniExcel/issues/413)
+        /// </summary>
+        [Fact]
+        public void TestIssue413()
+        {
+            var path = PathHelper.GetTempFilePath();
+            var value = new { 
+                list = new List<Dictionary<string,object>>{ 
+                    new Dictionary<string, object>{ { "id","001"},{ "time",new DateTime(2022,12,25)} },
+                    new Dictionary<string, object>{ { "id","002"},{ "time",new DateTime(2022,9,23)} },
+                } 
+            };
+            var templatePath = PathHelper.GetFile("xlsx/TestIssue413.xlsx");
+            MiniExcel.SaveAsByTemplate(path,templatePath, value);
+            var rows = MiniExcel.Query(path).ToList();
+            Assert.Equal("2022-12-25 00:00:00", rows[1].B);
+            Assert.Equal("2022-09-23 00:00:00", rows[2].B);
+        }
+
         /// <summary>
         /// [SaveAs Support empty sharedstring · Issue #405 · MiniExcel/MiniExcel]
         /// (https://github.com/MiniExcel/MiniExcel/issues/405)