[Bug] Fix SaveAs multiple sheet value error "Excel completed file level validation and repair. Some parts of this workbook may have been repaired or discarded." #325

Author: shps951023

docs/README.md

@@ -16,6 +16,9 @@
 
 ---
 
+### 0.21.5
+- [Bug] Fix SaveAs multiple sheet value error "Excel completed file level validation and repair. Some parts of this workbook may have been repaired or discarded."  #325
+
 ### 0.21.4
 - [New] Remove LISENCE_CODE check
 

docs/README.zh-CN.md

@@ -23,6 +23,9 @@
 
 ---
 
+### 0.21.5
+- [Bug] 修正 SaveAs multiple sheet value error "Excel completed file level validation and repair. Some parts of this workbook may have been repaired or discarded."  #325
+
 ### 0.21.4
 - [New] Remove LISENCE_CODE check
 

docs/README.zh-Hant.md

@@ -17,6 +17,9 @@
 
 ---
 
+### 0.21.5
+- [Bug] 修正 SaveAs multiple sheet value error "Excel completed file level validation and repair. Some parts of this workbook may have been repaired or discarded."  #325
+
 ### 0.21.4
 - [New] Remove LISENCE_CODE check
 

src/MiniExcel/MiniExcelLibs.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
 		<TargetFrameworks>net45;netstandard2.0;net5.0</TargetFrameworks>
-		<Version>0.21.4</Version>
+		<Version>0.21.5</Version>
 	</PropertyGroup>
 	<PropertyGroup>
 		<AssemblyName>MiniExcel</AssemblyName>

src/MiniExcel/OpenXml/ExcelOpenXmlSheetWriter.cs

@@ -637,7 +637,6 @@ private void GenerateEndXml()
             {
                 var workbookXml = new StringBuilder();
                 var workbookRelsXml = new StringBuilder();
-                var sheetRelsXml = new StringBuilder();
 
                 var sheetId = 0;
                 foreach (var s in _sheets)
@@ -648,9 +647,9 @@ private void GenerateEndXml()
 
                     //TODO: support multiple drawing 
                     //TODO: ../drawings/drawing1.xml or /xl/drawings/drawing1.xml
-                    sheetRelsXml.Append($@"<Relationship Type=""http://schemas.openxmlformats.org/officeDocument/2006/relationships/drawing"" Target=""../drawings/drawing1.xml"" Id=""drawing1"" />");
+                    var sheetRelsXml = $@"<Relationship Type=""http://schemas.openxmlformats.org/officeDocument/2006/relationships/drawing"" Target=""../drawings/drawing1.xml"" Id=""drawing1"" />";
                     CreateZipEntry($"xl/worksheets/_rels/sheet{s.SheetIdx}.xml.rels", "",
-                        _defaultSheetRelXml.Replace("{{format}}", sheetRelsXml.ToString()));
+                        _defaultSheetRelXml.Replace("{{format}}", sheetRelsXml));
                 }
                 CreateZipEntry(@"xl/workbook.xml", "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet.main+xml",
                     _defaultWorkbookXml.Replace("{{sheets}}", workbookXml.ToString()));

tests/MiniExcelTests/MiniExcelIssueTests.cs

@@ -18,6 +18,7 @@
 using static MiniExcelLibs.Tests.MiniExcelOpenXmlTests;
 using System.Collections;
 using MiniExcelLibs.Exceptions;
+using System.Text.RegularExpressions;
 
 namespace MiniExcelLibs.Tests
 {
@@ -29,6 +30,24 @@ public MiniExcelIssueTests(ITestOutputHelper output)
             this.output = output;
         }
 
+        /// <summary>
+        /// https://github.com/shps951023/MiniExcel/issues/325
+        /// </summary>
+        [Fact]
+        public void TestIssue325()
+        {
+            var path = PathHelper.GetTempFilePath();
+            var value = new Dictionary<string, object>()
+            {
+                { "sheet1",new[]{ new { id = 1, date = DateTime.Parse("2022-01-01") } }},
+                { "sheet2",new[]{ new { id = 2, date = DateTime.Parse("2022-01-01") } }},
+            };
+            MiniExcel.SaveAs(path, value);
+            var xml = Helpers.GetZipFileContent(path, "xl/worksheets/_rels/sheet2.xml.rels");
+            var cnt = Regex.Matches(xml, "Id=\"drawing1\"").Count;
+            Assert.True(cnt == 1);
+        }
+
         /// <summary>
         /// https://gitee.com/dotnetchina/MiniExcel/issues/I49RZH
         /// https://github.com/shps951023/MiniExcel/issues/305