[Bug] Fixed when CultureInfo likesff-Latn , datareader field type is datetime that will get error OA Date format #343

Author: shps951023

docs/README.md

@@ -24,6 +24,7 @@
 
 ### 1.24.3
 - [Bug] Fixed multiple threads Async error 'The given key N was not present in the dictionary' #344
+- [Bug] Fixed when CultureInfo likes`ff-Latn` , datareader field type is datetime that will get error OA Date format #343
 
 ### 1.24.2
 - [Bug] Fiexd Query multiple same title will cause startcell to get wrong column index #I4YCLQ 

docs/README.zh-CN.md

@@ -34,6 +34,7 @@
 
 ### 1.24.3
 - [Bug] 修正多 threads Async 可能错误 'The given key N was not present in the dictionary' #344
+- [Bug] 修正当 CultureInfo 像是`ff-Latn` , datareader field 类型是 datetime 系统会生成错误 OA Date 格式 #343
 
 ### 1.24.2
 - [Bug] Query 有多个相同标题会导致StartCell无法正确取得该栏位 #I4YCLQ 

docs/README.zh-Hant.md

@@ -26,6 +26,7 @@
 
 ### 1.24.3
 - [Bug] 修正多 threads Async 可能錯誤 'The given key N was not present in the dictionary' #344
+- [Bug] 修正當 CultureInfo 像是`ff-Latn` , datareader field 類型是 datetime 系統會生成錯誤 OA Date 格式 #343
 
 ### 1.24.2
 - [Bug] Query<T> 有多個相同標題會導致StartCell無法正確取得該欄位 #I4YCLQ 

src/MiniExcel/OpenXml/ExcelOpenXmlSheetWriter.cs

@@ -467,17 +467,18 @@ private void WriteCell(StreamWriter writer, int rowIndex, int cellIndex, object
                     {
                         t = null;
                         s = "3";
-                        v = ((DateTime)value).ToOADate().ToString();
+                        v = ((DateTime)value).ToOADate().ToString(CultureInfo.InvariantCulture);
                     }
                     else
                     {
                         // TODO: now it'll lose date type information
                         t = "str";
-                        v = ((DateTime)value).ToString(p.ExcelFormat);
+                        v = ((DateTime)value).ToString(p.ExcelFormat,_configuration.Culture);
                     }
                 }
                 else
                 {
+                    //TODO: _configuration.Culture
                     v = ExcelOpenXmlUtils.EncodeXML(value.ToString());       
                 }
             }

tests/MiniExcelTests/MiniExcelIssueTests.cs

@@ -21,9 +21,11 @@
 using System.Text.RegularExpressions;
 using MiniExcelLibs.Csv;
 using System.Threading.Tasks;
+using System.Data.SqlClient;
 
 namespace MiniExcelLibs.Tests
 {
+
     public partial class MiniExcelIssueTests
     {
         private readonly ITestOutputHelper output;
@@ -32,6 +34,32 @@ public MiniExcelIssueTests(ITestOutputHelper output)
             this.output = output;
         }
 
+        /// <summary>
+        /// Excel was unable to open the file https://github.com/shps951023/MiniExcel/issues/343
+        /// </summary>
+        [Fact]
+        public void TestIssue343()
+        {
+            {
+                var date = DateTime.Parse("2022-03-17 09:32:06.111", CultureInfo.InvariantCulture);
+                var path = PathHelper.GetTempFilePath();
+                CultureInfo.CurrentCulture = CultureInfo.GetCultureInfo("ff-Latn");
+                DataTable table = new DataTable();
+                {
+                    table.Columns.Add("time1", typeof(DateTime));
+                    table.Columns.Add("time2", typeof(DateTime));
+                    table.Rows.Add(date, date);
+                    table.Rows.Add(date, date);
+                }
+                DataTableReader reader = table.CreateDataReader();
+                MiniExcel.SaveAs(path, reader);
+
+                var rows = MiniExcel.Query(path,true).ToArray();
+                Assert.Equal(date, rows[0].time1);
+                Assert.Equal(date, rows[0].time2);
+            }
+        }
+
         [Fact]
         public void TestIssueI4YCLQ_2()
         {