[New] Remove overdue ExcelNumberFormat Dependency #271

Author: shps951023

docs/README.md

@@ -22,6 +22,9 @@
 
 ---
 
+### 1.25.2
+- [New] Remove overdue ExcelNumberFormat Dependency #271
+
 ### 1.25.1
 - [Bug] Fixed QueryAsDataTable read big file will throw NotImplementedException #360
 

docs/README.zh-CN.md

@@ -32,6 +32,9 @@
 
 ---
 
+### 1.25.2
+- [New] 移除过期的 ExcelNumberFormat Dependency #271
+
 ### 1.25.1
 - [Bug] 修正 QueryAsDataTable 读取大文件会抛出 NotImplementedException #360
 

docs/README.zh-Hant.md

@@ -24,6 +24,9 @@
 
 ---
 
+### 1.25.2
+- [New] 移除過期的 ExcelNumberFormat Dependency #271
+
 ### 1.25.1
 - [Bug] 修正 QueryAsDataTable 讀取大文件會拋出 NotImplementedException #360
 

src/MiniExcel/MiniExcelLibs.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
 		<TargetFrameworks>net45;netstandard2.0;net5.0</TargetFrameworks>
-		<Version>1.25.1</Version>
+		<Version>1.25.2</Version>
 	</PropertyGroup>
 	<PropertyGroup>
 		<AssemblyName>MiniExcel</AssemblyName>
@@ -42,7 +42,4 @@ Todo : https://github.com/shps951023/MiniExcel/projects/1?fullscreen=true
   <ItemGroup>
     <None Include="icon.png" Pack="true" PackagePath="\" />
   </ItemGroup>
-  <ItemGroup>
-    <PackageReference Include="ExcelNumberFormat" Version="1.1.0" />
-  </ItemGroup>	
 </Project>

src/MiniExcel/OpenXml/SharedStringsDiskCache.cs

@@ -13,14 +13,7 @@ internal class SharedStringsDiskCache : IDictionary<int, string>,IDisposable
         private readonly FileStream _valueFs;
         private bool _disposedValue;
         private readonly static Encoding _encoding = new System.Text.UTF8Encoding(true);
-        public ICollection<int> Keys => throw new NotImplementedException();
-
-        public ICollection<string> Values => throw new NotImplementedException();
-
-        public int Count => (int)(_maxIndx+1); 
-
-        public bool IsReadOnly => throw new NotImplementedException();
-
+        public int Count => (int)(_maxIndx+1);
         public string this[int key] { get => GetValue(key); set => Add(key,value); }
         private long _maxIndx = -1;
         public bool ContainsKey(int key)
@@ -96,7 +89,9 @@ public void Dispose()
             Dispose(disposing: true);
             GC.SuppressFinalize(this);
         }
-
+        public ICollection<int> Keys => throw new NotImplementedException();
+        public ICollection<string> Values => throw new NotImplementedException();
+        public bool IsReadOnly => throw new NotImplementedException();
         public bool Remove(int key)
         {
             throw new NotImplementedException();

src/MiniExcel/Utils/DateTimeHelper.cs

@@ -1,6 +1,6 @@
 namespace MiniExcelLibs.Utils
 {
-    using ExcelNumberFormat;
+    using MiniExcelLibs.Utils;
     using System;
     using System.Globalization;
 
@@ -11,7 +11,7 @@ internal static partial class DateTimeHelper
         /// </summary>
         public static bool IsDateTimeFormat(string formatCode)
         {
-            return new NumberFormat(formatCode).IsDateTimeFormat;
+            return new ExcelNumberFormat(formatCode).IsDateTimeFormat;
         }
     }