enhance: Cherry pick commits for client/2.5.5 (#43316)

Cherry pick from master
pr: #43126 #43243

Also bump client version to v2.5.5 preparing for releasing

---------

Signed-off-by: Congqi Xia <[email protected]>

Author: congqixia

client/column/columns.go

@@ -98,6 +98,7 @@ func parseScalarData[T any, COL Column, NCOL Column](
 	}
 	data = data[start:end]
 	if len(validData) > 0 {
+		validData = validData[start:end]
 		ncol, err := nullableCreator(name, data, validData, WithSparseNullableMode[T](true))
 		return ncol, err
 	}

client/common/version.go

@@ -18,5 +18,5 @@ package common
 
 const (
 	// SDKVersion const value for current version
-	SDKVersion = `2.5.4`
+	SDKVersion = `2.5.5`
 )

client/milvusclient/read.go

@@ -64,35 +64,42 @@ func (c *Client) handleSearchResult(schema *entity.Schema, outputFields []string
 	fieldDataList := results.GetFieldsData()
 	gb := results.GetGroupByFieldValue()
 	for i := 0; i < int(results.GetNumQueries()); i++ {
-		rc := int(results.GetTopks()[i]) // result entry count for current query
-		entry := ResultSet{
-			ResultCount: rc,
-			Scores:      results.GetScores()[offset : offset+rc],
-			sch:         schema,
-		}
+		func() {
+			var rc int
+			entry := ResultSet{
+				sch: schema,
+			}
+			defer func() {
+				offset += rc
+				sr = append(sr, entry)
+			}()
 
-		// set recall if returned
-		if i < len(results.Recalls) {
-			entry.Recall = results.Recalls[i]
-		}
+			if i >= len(results.Topks) {
+				entry.Err = errors.Newf("topk not returned for nq %d", i)
+				return
+			}
+			rc = int(results.GetTopks()[i]) // result entry count for current query
+			entry.ResultCount = rc
+			entry.Scores = results.GetScores()[offset : offset+rc]
 
-		entry.IDs, entry.Err = column.IDColumns(schema, results.GetIds(), offset, offset+rc)
-		if entry.Err != nil {
-			offset += rc
-			continue
-		}
-		// parse group-by values
-		if gb != nil {
-			entry.GroupByValue, entry.Err = column.FieldDataColumn(gb, offset, offset+rc)
-			if entry.Err != nil {
-				offset += rc
-				continue
+			// set recall if returned
+			if i < len(results.Recalls) {
+				entry.Recall = results.Recalls[i]
 			}
-		}
-		entry.Fields, entry.Err = c.parseSearchResult(schema, outputFields, fieldDataList, i, offset, offset+rc)
-		sr = append(sr, entry)
 
-		offset += rc
+			entry.IDs, entry.Err = column.IDColumns(schema, results.GetIds(), offset, offset+rc)
+			if entry.Err != nil {
+				return
+			}
+			// parse group-by values
+			if gb != nil {
+				entry.GroupByValue, entry.Err = column.FieldDataColumn(gb, offset, offset+rc)
+				if entry.Err != nil {
+					return
+				}
+			}
+			entry.Fields, entry.Err = c.parseSearchResult(schema, outputFields, fieldDataList, i, offset, offset+rc)
+		}()
 	}
 	return sr, nil
 }

client/milvusclient/read_test.go

@@ -62,8 +62,9 @@ func (s *ReadSuite) TestSearch() {
 							},
 						},
 					},
-					Scores: make([]float32, 10),
-					Topks:  []int64{10},
+					Scores:  make([]float32, 10),
+					Topks:   []int64{10},
+					Recalls: []float32{0.9},
 				},
 			}, nil
 		}).Once()
@@ -122,6 +123,54 @@ func (s *ReadSuite) TestSearch() {
 		s.NoError(err)
 	})
 
+	s.Run("bad_result", func() {
+		collectionName := fmt.Sprintf("coll_%s", s.randString(6))
+		partitionName := fmt.Sprintf("part_%s", s.randString(6))
+		s.setupCache(collectionName, s.schema)
+		s.mock.EXPECT().Search(mock.Anything, mock.Anything).RunAndReturn(func(ctx context.Context, sr *milvuspb.SearchRequest) (*milvuspb.SearchResults, error) {
+			s.Equal(collectionName, sr.GetCollectionName())
+			s.ElementsMatch([]string{partitionName}, sr.GetPartitionNames())
+
+			return &milvuspb.SearchResults{
+				Status: merr.Success(),
+				Results: &schemapb.SearchResultData{
+					NumQueries: 1,
+					TopK:       10,
+					FieldsData: []*schemapb.FieldData{
+						s.getInt64FieldData("ID", []int64{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}),
+					},
+					Ids: &schemapb.IDs{
+						IdField: &schemapb.IDs_IntId{
+							IntId: &schemapb.LongArray{
+								Data: []int64{1, 2, 3, 4, 5, 6, 7, 8, 9, 10},
+							},
+						},
+					},
+					Scores: make([]float32, 10),
+					Topks:  []int64{},
+				},
+			}, nil
+		}).Once()
+
+		ap := index.NewCustomAnnParam()
+		ap.WithExtraParam("custom_level", 1)
+		rss, err := s.client.Search(ctx, NewSearchOption(collectionName, 10, []entity.Vector{
+			entity.FloatVector(lo.RepeatBy(128, func(_ int) float32 {
+				return rand.Float32()
+			})),
+		}).WithPartitions(partitionName).
+			WithFilter("id > {tmpl_id}").
+			WithTemplateParam("tmpl_id", 100).
+			WithGroupByField("group_by").
+			WithSearchParam("ignore_growing", "true").
+			WithAnnParam(ap),
+		)
+		s.NoError(err)
+		s.Len(rss, 1)
+		rs := rss[0]
+		s.Error(rs.Err)
+	})
+
 	s.Run("failure", func() {
 		collectionName := fmt.Sprintf("coll_%s", s.randString(6))
 		s.setupCache(collectionName, s.schemaDyn)