fix: wait for debugger to be enabled before setting bps in vs

Fixes #1109

Author: connor4312

src/adapter/breakpoints.ts

@@ -525,6 +525,13 @@ export class BreakpointManager {
       await promise;
     }
 
+    const thread = this._thread;
+    if (thread?.debuggerReady.hasSettled() === false) {
+      const promise = thread.debuggerReady.promise;
+      this.addLaunchBlocker(promise);
+      await promise;
+    }
+
     // Creates new breakpoints for the parameters, unsetting any previous
     // breakpoints that don't still exist in the params.
     const mergeInto = (previous: UserDefinedBreakpoint[]): ISetBreakpointResult => {
@@ -594,7 +601,6 @@ export class BreakpointManager {
       this._uninstallSourceMapHandler(this._thread);
     }
 
-    const thread = this._thread;
     if (thread && result.new.length) {
       // This will add itself to the launch blocker if needed:
       this.ensureModuleEntryBreakpoint(thread, params.source);

src/adapter/threads.ts

@@ -157,6 +157,8 @@ export class Thread implements IVariableStoreDelegate {
   private readonly _dap: DeferredContainer<Dap.Api>;
   private disposed = false;
 
+  public debuggerReady = getDeferred<void>();
+
   /**
    * Details set when a "step in" is issued. Used allow async stepping in
    * sourcemapped worker scripts.
@@ -614,6 +616,7 @@ export class Thread implements IVariableStoreDelegate {
     // There is a bug in Chrome that does not retain debugger id
     // across cross-process navigations. Refresh it upon clearing contexts.
     this._cdp.Debugger.enable({}).then(response => {
+      this.debuggerReady.resolve();
       if (response) {
         Thread._allThreadsByDebuggerId.set(response.debuggerId, this);
       }

src/test/evaluate/evaluate-auto-expands-getter-447.txt

@@ -12,30 +12,12 @@
     > [[Prototype]]: Object
         > foo (set): ƒ foo(x) {}
         > [[Prototype]]: Object
-        > foo (set): ƒ foo(x) {}
-        > [[Prototype]]: Object
-        > arguments (get): ƒ ()
-        > arguments (set): ƒ ()
-        > caller (get): ƒ ()
-        > caller (set): ƒ ()
-        length: 1
-        > [[Prototype]]: ƒ ()
-        > [[Scopes]]: Scopes[0]
 
 > result: {}
     foo: 42
     > [[Prototype]]: Object
         foo: 42
         > [[Prototype]]: Object
-        foo: 42
-        > [[Prototype]]: Object
-        > arguments (get): ƒ ()
-        > arguments (set): ƒ ()
-        > caller (get): ƒ ()
-        > caller (set): ƒ ()
-        length: 1
-        > [[Prototype]]: ƒ ()
-        > [[Scopes]]: Scopes[0]
 
 > result: {}
     > foo (get): ƒ foo() { throw 'wat'; }
@@ -51,27 +33,9 @@
     > [[Prototype]]: Object
         > foo (get): ƒ foo() { throw 'wat'; }
         > [[Prototype]]: Object
-        > foo (get): ƒ foo() { throw 'wat'; }
-        > [[Prototype]]: Object
-        > arguments (get): ƒ ()
-        > arguments (set): ƒ ()
-        > caller (get): ƒ ()
-        > caller (set): ƒ ()
-        length: 1
-        > [[Prototype]]: ƒ ()
-        > [[Scopes]]: Scopes[0]
 
 > result: {}
     > [[Prototype]]: Object
         normalObject: true
         > [[Prototype]]: Object
-        normalObject: true
-        > [[Prototype]]: Object
-        > arguments (get): ƒ ()
-        > arguments (set): ƒ ()
-        > caller (get): ƒ ()
-        > caller (set): ƒ ()
-        length: 1
-        > [[Prototype]]: ƒ ()
-        > [[Scopes]]: Scopes[0]
 

src/test/evaluate/evaluate-default.txt

@@ -52,29 +52,13 @@ result: 3
     > [[Prototype]]: Object
         > foo (set): ƒ foo(x) {}
         > [[Prototype]]: Object
-        > Object
-        > arguments (get): ƒ ()
-        > arguments (set): ƒ ()
-        > caller (get): ƒ ()
-        > caller (set): ƒ ()
-        length: 1
-        > [[Prototype]]: ƒ ()
-        > [[Scopes]]: Scopes[0]
 
 > result: {}
     > foo (get): ƒ foo() { return 42 }
         42
     > [[Prototype]]: Object
         > foo (get): ƒ foo() { return 42 }
         > [[Prototype]]: Object
-        > Object
-        > arguments (get): ƒ ()
-        > arguments (set): ƒ ()
-        > caller (get): ƒ ()
-        > caller (set): ƒ ()
-        length: 1
-        > [[Prototype]]: ƒ ()
-        > [[Scopes]]: Scopes[0]
 
 > result: {}
     > foo (get): ƒ foo() { throw 'wat'; }
@@ -90,14 +74,6 @@ result: 3
     > [[Prototype]]: Object
         > foo (get): ƒ foo() { throw 'wat'; }
         > [[Prototype]]: Object
-        > Object
-        > arguments (get): ƒ ()
-        > arguments (set): ƒ ()
-        > caller (get): ƒ ()
-        > caller (set): ƒ ()
-        length: 1
-        > [[Prototype]]: ƒ ()
-        > [[Scopes]]: Scopes[0]
 
 Evaluating#1: setTimeout(() => { throw new Error('bar')}, 0)
 stderr> Uncaught Error: bar

src/test/node/node-runtime-sets-arguments.txt

@@ -9,3 +9,4 @@
     1: 'very fancy'
     2: '--arguments'
     length: 3
+    > __proto__: Array(0)

src/test/node/node-runtime.test.ts

@@ -673,8 +673,12 @@ describe('node runtime', () => {
       });
       handle.load();
 
-      handle.log(await handle.dap.once('stopped'));
-      handle.dap.evaluate({ expression: 'require("inspector").close()' });
+      const { threadId } = handle.log(await handle.dap.once('stopped'));
+      const stack = await handle.dap.stackTrace({ threadId });
+      handle.dap.evaluate({
+        expression: 'require("inspector").close()',
+        frameId: stack.stackFrames[0].id,
+      });
       handle.log(await handle.dap.once('terminated'));
       handle.assertLog({ substring: true });
     });

testWorkspace/simpleNode/debuggerStmt.js

@@ -1 +1,2 @@
+require('inspector'); // make sure require is available
 debugger;