Merge pull request #1382 from microsoft/fix/config-provider-types

connor4312 · connor4312 · commit 6e41ef5f7f12 · 2022-10-03T10:37:31.000-07:00
fix: dynamic debug configs sometimes having the wrong type
diff --git a/src/ui/configuration/baseConfigurationProvider.ts b/src/ui/configuration/baseConfigurationProvider.ts
@@ -44,7 +44,9 @@ export abstract class BaseConfigurationProvider<T extends AnyLaunchConfiguration
       const preferredType = preferredDebugTypes.get(this.type);
       if (preferredType) {
         for (const config of configs) {
-          config.type = preferredType as T['type'];
+          if (config.type === this.type) {
+            config.type = preferredType as T['type'];
+          }
         }
       }
 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,9 @@ export abstract class BaseConfigurationProvider<T extends AnyLaunchConfiguration`
`44`	`44`	`const preferredType = preferredDebugTypes.get(this.type);`
`45`	`45`	`if (preferredType) {`
`46`	`46`	`for (const config of configs) {`
`47`		`- config.type = preferredType as T['type'];`
	`47`	`+ if (config.type === this.type) {`
	`48`	`+ config.type = preferredType as T['type'];`
	`49`	`+ }`
`48`	`50`	`}`
`49`	`51`	`}`
`50`	`52`