Skip to content

Commit f10d0a8

Browse files
authored
devops: do not create non-removable folders on windows (#5533)
This fixes a bug where the script was creating a folder with a new line symbol in its name. As a result, Windows was failing to remove this folder, and Chromium Windows BuildBot was failing to even initialize checkout.
1 parent 1e327d4 commit f10d0a8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

browser_patches/chromium/archive.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ function archive_compiled_chromium() {
127127

128128
for ((i = 0; i < ${#CHROMIUM_FILES_TO_ARCHIVE[@]}; i++)) do
129129
file="${CHROMIUM_FILES_TO_ARCHIVE[$i]}"
130-
mkdir -p "output/${CHROMIUM_FOLDER_NAME}/$(dirname $file)"
130+
mkdir -p "output/${CHROMIUM_FOLDER_NAME}/$(dirname "${file}")"
131131
$COPY_COMMAND "${CR_CHECKOUT_PATH}/src/out/Default/${file}" "output/${CHROMIUM_FOLDER_NAME}/${file}"
132132
done
133133

0 commit comments

Comments
 (0)