test: convert evaluation.spec to jest+fixtures (#2968)

Author: pavelfeldman

.github/workflows/tests.yml

@@ -41,10 +41,10 @@ jobs:
       env:
         BROWSER: ${{ matrix.browser }}
         DEBUG: "*,-pw:wrapped*"
-    - run: xvfb-run --auto-servernum -- bash -c "ulimit -c unlimited && npm run jest 2>>./testrun.log"
+    - run: xvfb-run --auto-servernum -- bash -c "ulimit -c unlimited && npm run jest -- --testTimeout=30000"
+      if: ${{ always() }}
       env:
         BROWSER: ${{ matrix.browser }}
-        DEBUG: "*,-pw:wrapped*"
     - uses: actions/upload-artifact@v1
       if: failure()
       with:
@@ -80,10 +80,10 @@ jobs:
       env:
         BROWSER: ${{ matrix.browser }}
         DEBUG: "*,-pw:wrapped*"
-    - run: npm run jest 2>>./${{ matrix.browser }}-mac-testrun.log
+    - run: npm run jest -- --testTimeout=30000
+      if: ${{ always() }}
       env:
         BROWSER: ${{ matrix.browser }}
-        DEBUG: "*,-pw:wrapped*"
     - uses: actions/upload-artifact@v1
       if: failure()
       with:
@@ -115,11 +115,11 @@ jobs:
       env:
         BROWSER: ${{ matrix.browser }}
         DEBUG: "*,-pw:wrapped*"
-    - run: npm run jest 2>>./${{ matrix.browser }}-win-testrun.log
+    - run: npm run jest -- --testTimeout=30000
+      if: ${{ always() }}
       shell: bash
       env:
         BROWSER: ${{ matrix.browser }}
-        DEBUG: "*,-pw:wrapped*"
     - uses: actions/upload-artifact@v1
       if: failure()
       with:
@@ -170,6 +170,21 @@ jobs:
       env:
         DEBUG: "*"
         HEADLESS: "false"
+    - run: xvfb-run --auto-servernum -- bash -c "ulimit -c unlimited && npm run jest -- --testTimeout=30000"
+      if: ${{ always() }}
+      env:
+        BROWSER: "chromium"
+        HEADLESS: "false"
+    - run: xvfb-run --auto-servernum -- bash -c "ulimit -c unlimited && npm run jest -- --testTimeout=30000"
+      if: ${{ always() }}
+      env:
+        BROWSER: "firefox"
+        HEADLESS: "false"
+    - run: xvfb-run --auto-servernum -- bash -c "ulimit -c unlimited && npm run jest -- --testTimeout=30000"
+      if: ${{ always() }}
+      env:
+        BROWSER: "webkit"
+        HEADLESS: "false"
     - uses: actions/upload-artifact@v1
       if: failure()
       with:
@@ -208,6 +223,11 @@ jobs:
         BROWSER: ${{ matrix.browser }}
         DEBUG: "*,-pw:wrapped*"
         PWCHANNEL: ${{ matrix.transport }}
+    - run: xvfb-run --auto-servernum -- bash -c "ulimit -c unlimited && npm run jest -- --testTimeout=30000"
+      if: ${{ always() }}
+      env:
+        BROWSER: ${{ matrix.browser }}
+        PWCHANNEL: ${{ matrix.transport }}
     - uses: actions/upload-artifact@v1
       if: failure()
       with:

jest.config.json

@@ -1,6 +1,9 @@
 {
-  "rootDir": "./test/jest",
-  "testEnvironment": ".",
-  "testMatch":  ["**/?(*.)spec.[jt]s"],
-  "testRunner": "jest-circus/runner"
+  "rootDir": "./test",
+  "testEnvironment": "./jest",
+  "testMatch":  ["**/?(*.)jest.[jt]s"],
+  "testRunner": "jest-circus/runner",
+  "testTimeout": 10000,
+  "globalSetup": "./jest/setup.js",
+  "globalTeardown": "./jest/teardown.js"
 }

package-lock.json

@@ -16,10 +16,6 @@
     "ftest": "cross-env BROWSER=firefox node --unhandled-rejections=strict test/test.js",
     "wtest": "cross-env BROWSER=webkit node --unhandled-rejections=strict test/test.js",
     "test": "cross-env node --unhandled-rejections=strict test/test.js",
-    "cunit": "cross-env BROWSER=chromium node --unhandled-rejections=strict test/test.js",
-    "funit": "cross-env BROWSER=firefox node --unhandled-rejections=strict test/test.js",
-    "wunit": "cross-env BROWSER=webkit node --unhandled-rejections=strict test/test.js",
-    "unit": "cross-env node --unhandled-rejections=strict test/test.js",
     "ccoverage": "cross-env COVERAGE=true BROWSER=chromium node --unhandled-rejections=strict test/test.js",
     "fcoverage": "cross-env COVERAGE=true BROWSER=firefox node --unhandled-rejections=strict test/test.js",
     "wcoverage": "cross-env COVERAGE=true BROWSER=webkit node --unhandled-rejections=strict test/test.js",
@@ -83,6 +79,7 @@
     "formidable": "^1.2.1",
     "jest": "^26.1.0",
     "jest-circus": "^26.1.0",
+    "jest-image-snapshot": "^4.0.2",
     "ncp": "^2.0.0",
     "node-stream-zip": "^1.8.2",
     "pirates": "^4.0.1",

package.json

@@ -14,6 +14,14 @@
  * limitations under the License.
  */
 
+function isRegExp(obj: any): obj is RegExp {
+  return obj instanceof RegExp || Object.prototype.toString.call(obj) === '[object RegExp]';
+}
+
+function isDate(obj: any): obj is Date {
+  return obj instanceof Date || Object.prototype.toString.call(obj) === '[object Date]';
+}
+
 export function parseEvaluationResultValue(value: any, handles: any[] = []): any {
   if (value === undefined)
     return undefined;
@@ -85,9 +93,9 @@ function serialize(value: any, jsHandleSerializer: (value: any) => { fallThrough
     }
     return `${error.name}: ${error.message}\n${error.stack}`;
   }
-  if (value instanceof Date)
+  if (isDate(value))
     return { d: value.toJSON() };
-  if (value instanceof RegExp)
+  if (isRegExp(value))
     return { r: [ value.source, value.flags ] };
 
   if (Array.isArray(value)) {

src/common/utilityScriptSerializers.ts

@@ -180,7 +180,6 @@ class PlaywrightEnvironment {
           if (!this.expectExit)
             throw new Error(`Server closed with exitCode=${exitCode} signal=${signal}`);
         });
-        process.on('exit', () => this._killProcess());
         const transport = new Transport(this.spawnedProcess.stdin, this.spawnedProcess.stdout);
         connection.onmessage = message => transport.send(JSON.stringify(message));
         transport.onmessage = message => connection.dispatch(JSON.parse(message));
@@ -213,20 +212,6 @@ class PlaywrightEnvironment {
     }
     delete state.playwright;
   }
-
-  _killProcess() {
-    if (this.spawnedProcess && this.spawnedProcess.pid) {
-      this.expectExit = true;
-      try {
-        if (process.platform === 'win32')
-          childProcess.execSync(`taskkill /pid ${this.spawnedProcess.pid} /T /F`);
-        else
-          process.kill(-this.spawnedProcess.pid, 'SIGKILL');
-      } catch (e) {
-        // the process might have already stopped
-      }
-    }
-  }
 }
 
 class BrowserTypeEnvironment {

test/environments.js

@@ -17,7 +17,6 @@
 
 const utils = require('./utils');
 const path = require('path');
-const {FFOX, CHROMIUM, WEBKIT, USES_HOOKS, CHANNEL} = utils.testOptions(browserType);
 
 describe('Page.evaluate', function() {
   it('should work', async({page, server}) => {
@@ -357,7 +356,7 @@ describe('Page.evaluate', function() {
     });
     expect(result).toEqual([42]);
   });
-  it.fail(WEBKIT)('should not throw an error when evaluation does a synchronous navigation and returns an object', async({page, server}) => {
+  (WEBKIT ? it.skip : it)('should not throw an error when evaluation does a synchronous navigation and returns an object', async({page, server}) => {
     // It is imporant to be on about:blank for sync reload.
     const result = await page.evaluate(() => {
       window.location.reload();
@@ -373,7 +372,7 @@ describe('Page.evaluate', function() {
     });
     expect(result).toBe(undefined);
   });
-  it.slow().skip(CHANNEL)('should transfer 100Mb of data from page to node.js', async({page, server}) => {
+  (CHANNEL ? it.skip : it)('should transfer 100Mb of data from page to node.js', async({page}) => {
     const a = await page.evaluate(() => Array(100 * 1024 * 1024 + 1).join('a'));
     expect(a.length).toBe(100 * 1024 * 1024);
   });
@@ -389,7 +388,7 @@ describe('Page.evaluate', function() {
     const result = await page.evaluate(() => ({abc: 123}));
     expect(result).toEqual({abc: 123});
   });
-  it.fail(FFOX)('should await promise from popup', async function({page, server}) {
+  (FFOX ? it.skip : it)('should await promise from popup', async ({page, server}) => {
     // Something is wrong about the way Firefox waits for the chained promise
     await page.goto(server.EMPTY_PAGE);
     const result = await page.evaluate(() => {
@@ -574,14 +573,14 @@ describe('Frame.evaluate', function() {
     else
       expect(pageImpl._delegate._contextIdToContext.size).toBe(count);
   }
-  it.skip(USES_HOOKS)('should dispose context on navigation', async({page, server, toImpl}) => {
+  (USES_HOOKS ? it.skip : it)('should dispose context on navigation', async({page, server, toImpl}) => {
     await page.goto(server.PREFIX + '/frames/one-frame.html');
     expect(page.frames().length).toBe(2);
     expectContexts(toImpl(page), 4);
     await page.goto(server.EMPTY_PAGE);
     expectContexts(toImpl(page), 2);
   });
-  it.skip(USES_HOOKS)('should dispose context on cross-origin navigation', async({page, server, toImpl}) => {
+  (USES_HOOKS ? it.skip : it)('should dispose context on cross-origin navigation', async({page, server, toImpl}) => {
     await page.goto(server.PREFIX + '/frames/one-frame.html');
     expect(page.frames().length).toBe(2);
     expectContexts(toImpl(page), 4);