Skip to content

Commit ebb4c33

Browse files
authored
test: mark 2 chromium not important win tests as failed (#2914)
1 parent 982e5e3 commit ebb4c33

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test/chromium/launcher.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ describe('launcher', function() {
3232
const browser = await browserType.launchServer(options);
3333
await browser.close();
3434
});
35-
it.skip(USES_HOOKS)('should open devtools when "devtools: true" option is given', async({browserType, defaultBrowserOptions}) => {
35+
it.skip(USES_HOOKS).fail(CHROMIUM && WIN)('should open devtools when "devtools: true" option is given', async({browserType, defaultBrowserOptions}) => {
3636
let devtoolsCallback;
3737
const devtoolsPromise = new Promise(f => devtoolsCallback = f);
3838
const __testHookForDevTools = devtools => devtools.__testHookOnBinding = parsed => {

test/launcher.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ describe('browserType.connect', function() {
299299
await browserServer._checkLeaks();
300300
await browserServer.close();
301301
});
302-
it.skip(USES_HOOKS).slow()('should handle exceptions during connect', async({browserType, defaultBrowserOptions, server}) => {
302+
it.skip(USES_HOOKS).slow().fail(CHROMIUM && WIN)('should handle exceptions during connect', async({browserType, defaultBrowserOptions, server}) => {
303303
const browserServer = await browserType.launchServer(defaultBrowserOptions);
304304
const __testHookBeforeCreateBrowser = () => { throw new Error('Dummy') };
305305
const error = await browserType.connect({ wsEndpoint: browserServer.wsEndpoint(), __testHookBeforeCreateBrowser }).catch(e => e);

0 commit comments

Comments
 (0)