Skip to content

Commit ea32ad2

Browse files
authored
infra(channel): add edge stable bot (#5825)
1 parent 95affe9 commit ea32ad2

File tree

3 files changed

+30
-2
lines changed

3 files changed

+30
-2
lines changed

.github/workflows/tests.yml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,3 +294,32 @@ jobs:
294294
with:
295295
name: chrome-stable-test-results
296296
path: test-results
297+
298+
edge_stable:
299+
name: "Edge Stable (Win)"
300+
runs-on: windows-latest
301+
steps:
302+
- name: Install Media Pack
303+
shell: powershell
304+
run: Install-WindowsFeature Server-Media-Foundation
305+
- uses: actions/checkout@v2
306+
- uses: actions/setup-node@v1
307+
with:
308+
node-version: 10
309+
- run: npm ci
310+
env:
311+
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
312+
- run: npm run build
313+
# This only created problems, should we move ffmpeg back into npm?
314+
- run: node lib/cli/cli install ffmpeg
315+
- run: npx folio test/ --workers=1 --forbid-only --global-timeout=5400000 --retries=3 --reporter=dot,json
316+
shell: bash
317+
env:
318+
BROWSER: "chromium"
319+
PW_CHROMIUM_CHANNEL: "msedge"
320+
FOLIO_JSON_OUTPUT_NAME: "test-results/report.json"
321+
- uses: actions/upload-artifact@v1
322+
if: ${{ always() }}
323+
with:
324+
name: edge-stable-test-results
325+
path: test-results

src/server/browserType.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ export abstract class BrowserType extends SdkObject {
178178
}
179179

180180
if (!executable) {
181-
// We can only validate dependencies for bundled browsers.
181+
// Only validate dependencies for bundled browsers.
182182
await validateHostRequirements(this._registry, this._name);
183183
}
184184

test/downloads-path.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ fixtures.persistentDownloadsContext.init(async ({ server, launchPersistent, test
5050
{
5151
downloadsPath: testInfo.outputPath(''),
5252
acceptDownloads: true,
53-
channel: browserChannel,
5453
}
5554
);
5655
logOnCI('--- setting content for the page ---');

0 commit comments

Comments
 (0)