Skip to content

Commit e97badc

Browse files
rwollaslushnikov
andauthored
docs(CONTRIBUTING.md): Add build step (#2869)
* docs(CONTRIBUTING.md): Add build step Without the build step, a fresh install without any previous builds would get: ``` $ npm test > [email protected] test /Users/pw/code/playwright > cross-env BROWSER=all node --unhandled-rejections=strict test/test.js internal/modules/cjs/loader.js:1033 throw err; ^ Error: Cannot find module '../lib/rpc/server/dispatcher' Require stack: - /Users/pw/code/playwright/test/environments.js - /Users/pw/code/playwright/test/test.js at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1030:15) at Function.Module._load (internal/modules/cjs/loader.js:899:27) at Module.require (internal/modules/cjs/loader.js:1090:19) at require (internal/modules/cjs/helpers.js:75:18) at Object.<anonymous> (/Users/pw/code/playwright/test/environments.js:23:34) at Module._compile (internal/modules/cjs/loader.js:1201:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10) at Module.load (internal/modules/cjs/loader.js:1050:32) at Function.Module._load (internal/modules/cjs/loader.js:938:14) at Module.require (internal/modules/cjs/loader.js:1090:19) { code: 'MODULE_NOT_FOUND', requireStack: [ '/Users/pw/code/playwright/test/environments.js', '/Users/pw/code/playwright/test/test.js' ] } npm ERR! Test failed. See above for more details. ``` Fixes #2868. Co-authored-by: Andrey Lushnikov <[email protected]>
1 parent 760283e commit e97badc

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,13 @@ cd playwright
3232
npm install
3333
```
3434

35-
3. Run all Playwright tests locally. For more information about tests, read [Running & Writing Tests](#running--writing-tests).
35+
3. Build Playwright
36+
37+
```bash
38+
npm run build
39+
```
40+
41+
4. Run all Playwright tests locally. For more information about tests, read [Running & Writing Tests](#running--writing-tests).
3642

3743
```bash
3844
npm test

0 commit comments

Comments
 (0)