Skip to content

Commit e90ba26

Browse files
fix(context): fire close event for persistent contexts (#2891)
1 parent 8fe29fe commit e90ba26

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

src/browser.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ export abstract class BrowserBase extends EventEmitter implements Browser {
9292
_didClose() {
9393
for (const context of this.contexts())
9494
(context as BrowserContextBase)._browserClosed();
95+
if (this._defaultContext)
96+
this._defaultContext._browserClosed();
9597
this.emit(Events.Browser.Disconnected);
9698
}
9799

test/defaultbrowsercontext.spec.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -367,4 +367,11 @@ describe('launchPersistentContext()', function() {
367367
expect(error).toBe(e);
368368
await removeUserDataDir(userDataDir);
369369
});
370+
it('should fire close event for a persistent context', async(state) => {
371+
const {context} = await launch(state);
372+
let closed = false;
373+
context.on('close', () => closed = true);
374+
await close(state);
375+
expect(closed).toBe(true);
376+
});
370377
});

0 commit comments

Comments
 (0)