Skip to content

Commit ca49d50

Browse files
test: disable firefox popup tests that rely on waitForLoadState (#768)
We have a race between opening a popup and calling waitForLoadState that sometimes causes waitForLoadState to timeout.
1 parent 1344596 commit ca49d50

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/page.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF
139139
expect(await page.evaluate(() => !!window.opener)).toBe(false);
140140
expect(await popup.evaluate(() => !!window.opener)).toBe(false);
141141
});
142-
it('should work with clicking target=_blank', async({page, server}) => {
142+
it.skip(FFOX)('should work with clicking target=_blank', async({page, server}) => {
143143
await page.goto(server.EMPTY_PAGE);
144144
await page.setContent('<a target=_blank rel="opener" href="/one-style.html">yo</a>');
145145
const [popup] = await Promise.all([
@@ -162,7 +162,7 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF
162162
// FFOX is slow enough to trigger this. We should do something about popups api.
163163
expect(await popup.evaluate(() => !!window.opener)).toBe(false);
164164
});
165-
it('should work with clicking target=_blank and rel=noopener', async({page, server}) => {
165+
it.skip(FFOX)('should work with clicking target=_blank and rel=noopener', async({page, server}) => {
166166
await page.goto(server.EMPTY_PAGE);
167167
await page.setContent('<a target=_blank rel=noopener href="/one-style.html">yo</a>');
168168
const [popup] = await Promise.all([

0 commit comments

Comments
 (0)