Skip to content

Commit c4a2732

Browse files
authored
browser(webkit): another mac fix (#3948)
1 parent ce51af0 commit c4a2732

File tree

2 files changed

+28
-28
lines changed

2 files changed

+28
-28
lines changed

browser_patches/webkit/BUILD_NUMBER

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
1346
2-
Changed: [email protected] Mon Sep 21 17:56:58 PDT 2020
1+
1347
2+
Changed: [email protected] Mon Sep 21 19:01:22 PDT 2020

browser_patches/webkit/patches/bootstrap.diff

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2655,7 +2655,7 @@ index f6c83ea43b81e59816130269a28b1a6623b99854..69d4f43dc676e6c1fa08146ca704cf36
26552655
+
26562656
} // namespace WebCore
26572657
diff --git a/Source/WebCore/inspector/agents/InspectorDOMAgent.h b/Source/WebCore/inspector/agents/InspectorDOMAgent.h
2658-
index 7f2872df49e0d40ab020cd9884ded00308f1a2a6..d29615ad8f2dedcadd4ee2dd422f53ff3858f9e1 100644
2658+
index 7f2872df49e0d40ab020cd9884ded00308f1a2a6..a2512f35fdea0d0f6ea9393354461e022c2576f3 100644
26592659
--- a/Source/WebCore/inspector/agents/InspectorDOMAgent.h
26602660
+++ b/Source/WebCore/inspector/agents/InspectorDOMAgent.h
26612661
@@ -55,6 +55,7 @@ namespace WebCore {
@@ -2679,18 +2679,18 @@ index 7f2872df49e0d40ab020cd9884ded00308f1a2a6..d29615ad8f2dedcadd4ee2dd422f53ff
26792679
Inspector::Protocol::ErrorStringOr<Ref<JSON::ArrayOf<Inspector::Protocol::DOM::NodeId>>> getSearchResults(const String& searchId, int fromIndex, int toIndex);
26802680
Inspector::Protocol::ErrorStringOr<void> discardSearchResults(const String& searchId);
26812681
- Inspector::Protocol::ErrorStringOr<Ref<Inspector::Protocol::Runtime::RemoteObject>> resolveNode(Inspector::Protocol::DOM::NodeId, const String& objectGroup);
2682-
+ Inspector::Protocol::ErrorStringOr<Ref<Inspector::Protocol::Runtime::RemoteObject>> resolveNode(Optional<Inspector::Protocol::DOM::NodeId>&& nodeId, const String& objectId, Optional<int>&& contextId, const String& objectGroup) override;
2682+
+ Inspector::Protocol::ErrorStringOr<Ref<Inspector::Protocol::Runtime::RemoteObject>> resolveNode(Optional<Inspector::Protocol::DOM::NodeId>&& nodeId, const String& objectId, Optional<int>&& contextId, const String& objectGroup);
26832683
Inspector::Protocol::ErrorStringOr<Ref<JSON::ArrayOf<String>>> getAttributes(Inspector::Protocol::DOM::NodeId);
26842684
#if PLATFORM(IOS_FAMILY)
26852685
Inspector::Protocol::ErrorStringOr<void> setInspectModeEnabled(bool, RefPtr<JSON::Object>&& highlightConfig);
26862686
@@ -153,6 +155,10 @@ public:
26872687
Inspector::Protocol::ErrorStringOr<void> focus(Inspector::Protocol::DOM::NodeId);
26882688
Inspector::Protocol::ErrorStringOr<void> setInspectedNode(Inspector::Protocol::DOM::NodeId);
26892689
Inspector::Protocol::ErrorStringOr<void> setAllowEditingUserAgentShadowTrees(bool);
2690-
+ Inspector::Protocol::ErrorStringOr<std::tuple<String /* contentFrameId */, String /* ownerFrameId */>> describeNode(const String& objectId) override;
2691-
+ Inspector::Protocol::ErrorStringOr<void> scrollIntoViewIfNeeded(const String& objectId, RefPtr<JSON::Object>&& rect) override;
2692-
+ Inspector::Protocol::ErrorStringOr<Ref<JSON::ArrayOf<Inspector::Protocol::DOM::Quad>>> getContentQuads(const String& objectId) override;
2693-
+ Inspector::Protocol::ErrorStringOr<void> setInputFiles(const String& objectId, Ref<JSON::Array>&& files) override;
2690+
+ Inspector::Protocol::ErrorStringOr<std::tuple<String /* contentFrameId */, String /* ownerFrameId */>> describeNode(const String& objectId);
2691+
+ Inspector::Protocol::ErrorStringOr<void> scrollIntoViewIfNeeded(const String& objectId, RefPtr<JSON::Object>&& rect);
2692+
+ Inspector::Protocol::ErrorStringOr<Ref<JSON::ArrayOf<Inspector::Protocol::DOM::Quad>>> getContentQuads(const String& objectId);
2693+
+ Inspector::Protocol::ErrorStringOr<void> setInputFiles(const String& objectId, Ref<JSON::Array>&& files);
26942694

26952695
// InspectorInstrumentation
26962696
Inspector::Protocol::DOM::NodeId identifierForNode(Node&);
@@ -3713,7 +3713,7 @@ index ae25fcebc93d504bb0abf17b61bbe1d73efcc1e3..9d0cc967efe17c6fc94e694d8806e1c4
37133713
+
37143714
} // namespace WebCore
37153715
diff --git a/Source/WebCore/inspector/agents/InspectorPageAgent.h b/Source/WebCore/inspector/agents/InspectorPageAgent.h
3716-
index d2b065e13651fafe747325f02e7701fbf1e8e45e..9076ff5fa9b746f9f13823146504829593f11bef 100644
3716+
index d2b065e13651fafe747325f02e7701fbf1e8e45e..3b5db3e7404fc890acab9864d23bbbc6b54b27fd 100644
37173717
--- a/Source/WebCore/inspector/agents/InspectorPageAgent.h
37183718
+++ b/Source/WebCore/inspector/agents/InspectorPageAgent.h
37193719
@@ -34,17 +34,23 @@
@@ -3759,32 +3759,32 @@ index d2b065e13651fafe747325f02e7701fbf1e8e45e..9076ff5fa9b746f9f138231465048295
37593759
Inspector::Protocol::ErrorStringOr<void> enable();
37603760
Inspector::Protocol::ErrorStringOr<void> disable();
37613761
Inspector::Protocol::ErrorStringOr<void> reload(Optional<bool>&& ignoreCache, Optional<bool>&& revalidateAllResources);
3762-
+ Inspector::Protocol::ErrorStringOr<void> goBack() override;
3763-
+ Inspector::Protocol::ErrorStringOr<void> goForward() override;
3762+
+ Inspector::Protocol::ErrorStringOr<void> goBack();
3763+
+ Inspector::Protocol::ErrorStringOr<void> goForward();
37643764
Inspector::Protocol::ErrorStringOr<void> navigate(const String& url);
37653765
Inspector::Protocol::ErrorStringOr<void> overrideUserAgent(const String&);
37663766
Inspector::Protocol::ErrorStringOr<void> overrideSetting(Inspector::Protocol::Page::Setting, Optional<bool>&& value);
37673767
@@ -114,22 +124,34 @@ public:
37683768
#if ENABLE(DARK_MODE_CSS) || HAVE(OS_DARK_MODE_SUPPORT)
37693769
Inspector::Protocol::ErrorStringOr<void> setForcedAppearance(Optional<Inspector::Protocol::Page::Appearance>&&);
37703770
#endif
3771-
+ Inspector::Protocol::ErrorStringOr<void> setTimeZone(const String&) override;
3772-
+ Inspector::Protocol::ErrorStringOr<void> setTouchEmulationEnabled(bool) override;
3771+
+ Inspector::Protocol::ErrorStringOr<void> setTimeZone(const String&);
3772+
+ Inspector::Protocol::ErrorStringOr<void> setTouchEmulationEnabled(bool);
37733773
Inspector::Protocol::ErrorStringOr<String> snapshotNode(Inspector::Protocol::DOM::NodeId);
37743774
Inspector::Protocol::ErrorStringOr<String> snapshotRect(int x, int y, int width, int height, Inspector::Protocol::Page::CoordinateSystem);
37753775
#if ENABLE(WEB_ARCHIVE) && USE(CF)
37763776
Inspector::Protocol::ErrorStringOr<String> archive();
37773777
#endif
37783778

3779-
+ Inspector::Protocol::ErrorStringOr<void> insertText(const String& text) override;
3780-
+ Inspector::Protocol::ErrorStringOr<Ref<Inspector::Protocol::Page::AXNode>> accessibilitySnapshot(const String& objectId) override;
3781-
+ Inspector::Protocol::ErrorStringOr<void> setInterceptFileChooserDialog(bool enabled) override;
3782-
+ Inspector::Protocol::ErrorStringOr<void> setDefaultBackgroundColorOverride(RefPtr<JSON::Object>&&) override;
3783-
+ Inspector::Protocol::ErrorStringOr<void> createUserWorld(const String&) override;
3784-
+ Inspector::Protocol::ErrorStringOr<void> setBypassCSP(bool) override;
3785-
+ Inspector::Protocol::ErrorStringOr<void> crash()override;
3786-
+ Inspector::Protocol::ErrorStringOr<void> setScreenSizeOverride(int width, int height) override;
3787-
+ Inspector::Protocol::ErrorStringOr<void> setOrientationOverride(Optional<int>&& angle) override;
3779+
+ Inspector::Protocol::ErrorStringOr<void> insertText(const String& text);
3780+
+ Inspector::Protocol::ErrorStringOr<Ref<Inspector::Protocol::Page::AXNode>> accessibilitySnapshot(const String& objectId);
3781+
+ Inspector::Protocol::ErrorStringOr<void> setInterceptFileChooserDialog(bool enabled);
3782+
+ Inspector::Protocol::ErrorStringOr<void> setDefaultBackgroundColorOverride(RefPtr<JSON::Object>&&);
3783+
+ Inspector::Protocol::ErrorStringOr<void> createUserWorld(const String&);
3784+
+ Inspector::Protocol::ErrorStringOr<void> setBypassCSP(bool);
3785+
+ Inspector::Protocol::ErrorStringOr<void> crash();
3786+
+ Inspector::Protocol::ErrorStringOr<void> setScreenSizeOverride(int width, int height);
3787+
+ Inspector::Protocol::ErrorStringOr<void> setOrientationOverride(Optional<int>&& angle);
37883788
+
37893789
// InspectorInstrumentation
37903790
- void domContentEventFired();
@@ -11548,7 +11548,7 @@ index 04f3227cd55c992a42cd96a3f25d697aed7965a2..f0d36935f47bab03ea2ec50b70509206
1154811548

1154911549
diff --git a/Source/WebKit/UIProcess/WebPageInspectorEmulationAgent.cpp b/Source/WebKit/UIProcess/WebPageInspectorEmulationAgent.cpp
1155011550
new file mode 100644
11551-
index 0000000000000000000000000000000000000000..c09db72a276875db36077bb49f8c7d6ff7b4eb8f
11551+
index 0000000000000000000000000000000000000000..e6e700e846ea091a190b6b1f5c5636fed4389909
1155211552
--- /dev/null
1155311553
+++ b/Source/WebKit/UIProcess/WebPageInspectorEmulationAgent.cpp
1155411554
@@ -0,0 +1,146 @@
@@ -11645,15 +11645,15 @@ index 0000000000000000000000000000000000000000..c09db72a276875db36077bb49f8c7d6f
1164511645
+ });
1164611646
+}
1164711647
+
11648-
+Protocol::ErrorStringOr<void> WebPageInspectorEmulationAgent::setJavaScriptEnabled(bool enabled)
11648+
+Inspector::Protocol::ErrorStringOr<void> WebPageInspectorEmulationAgent::setJavaScriptEnabled(bool enabled)
1164911649
+{
1165011650
+ auto copy = m_page.preferences().copy();
1165111651
+ copy->setJavaScriptEnabled(enabled);
1165211652
+ m_page.setPreferences(copy);
1165311653
+ return { };
1165411654
+}
1165511655
+
11656-
+Protocol::ErrorStringOr<void> WebPageInspectorEmulationAgent::setAuthCredentials(const String& username, const String& password)
11656+
+Inspector::Protocol::ErrorStringOr<void> WebPageInspectorEmulationAgent::setAuthCredentials(const String& username, const String& password)
1165711657
+{
1165811658
+ if (!!username && !!password)
1165911659
+ m_page.setAuthCredentialsForAutomation(WebCore::Credential(username, password, CredentialPersistencePermanent));
@@ -11662,13 +11662,13 @@ index 0000000000000000000000000000000000000000..c09db72a276875db36077bb49f8c7d6f
1166211662
+ return { };
1166311663
+}
1166411664
+
11665-
+Protocol::ErrorStringOr<void> WebPageInspectorEmulationAgent::setActiveAndFocused(Optional<bool>&& active)
11665+
+Inspector::Protocol::ErrorStringOr<void> WebPageInspectorEmulationAgent::setActiveAndFocused(Optional<bool>&& active)
1166611666
+{
1166711667
+ m_page.setActiveForAutomation(WTFMove(active));
1166811668
+ return { };
1166911669
+}
1167011670
+
11671-
+Protocol::ErrorStringOr<void> WebPageInspectorEmulationAgent::grantPermissions(const String& origin, Ref<JSON::Array>&& values)
11671+
+Inspector::Protocol::ErrorStringOr<void> WebPageInspectorEmulationAgent::grantPermissions(const String& origin, Ref<JSON::Array>&& values)
1167211672
+{
1167311673
+ HashSet<String> set;
1167411674
+ for (const auto& value : values.get()) {
@@ -11683,7 +11683,7 @@ index 0000000000000000000000000000000000000000..c09db72a276875db36077bb49f8c7d6f
1168311683
+ return { };
1168411684
+}
1168511685
+
11686-
+Protocol::ErrorStringOr<void> WebPageInspectorEmulationAgent::resetPermissions()
11686+
+Inspector::Protocol::ErrorStringOr<void> WebPageInspectorEmulationAgent::resetPermissions()
1168711687
+{
1168811688
+ m_permissions.clear();
1168911689
+ m_page.setPermissionsForAutomation(m_permissions);

0 commit comments

Comments
 (0)