fix(inspector): await inspector init to avoid races (#5829)

pavelfeldman · web-flow · commit c2db8da4df4b · 2021-03-15T19:02:38.000-07:00
diff --git a/src/server/supplements/inspectorController.ts b/src/server/supplements/inspectorController.ts
@@ -25,7 +25,7 @@ export class InspectorController implements InstrumentationListener {
 
   async onContextCreated(context: BrowserContext): Promise<void> {
     if (isDebugMode())
-      RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true });
+      await RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true });
   }
 
   async onBeforeCall(sdkObject: SdkObject, metadata: CallMetadata): Promise<void> {
@@ -53,7 +53,7 @@ export class InspectorController implements InstrumentationListener {
     }
 
     if (shouldOpenInspector(sdkObject, metadata))
-      RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true });
+      await RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true });
 
     const recorder = await RecorderSupplement.getNoCreate(context);
     await recorder?.onBeforeCall(sdkObject, metadata);

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export class InspectorController implements InstrumentationListener {`
`25`	`25`
`26`	`26`	`async onContextCreated(context: BrowserContext): Promise<void> {`
`27`	`27`	`if (isDebugMode())`
`28`		`- RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true });`
	`28`	`+ await RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true });`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`async onBeforeCall(sdkObject: SdkObject, metadata: CallMetadata): Promise<void> {`
`@@ -53,7 +53,7 @@ export class InspectorController implements InstrumentationListener {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`if (shouldOpenInspector(sdkObject, metadata))`
`56`		`- RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true });`
	`56`	`+ await RecorderSupplement.getOrCreate(context, { pauseOnNextStatement: true });`
`57`	`57`
`58`	`58`	`const recorder = await RecorderSupplement.getNoCreate(context);`
`59`	`59`	`await recorder?.onBeforeCall(sdkObject, metadata);`