Skip to content

Commit bf7dff8

Browse files
committed
chore: remove the --only-update-browsers option
1 parent 20c17d5 commit bf7dff8

File tree

3 files changed

+14
-19
lines changed

3 files changed

+14
-19
lines changed

utils/doclint/cli.js

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ run().catch(e => {
3939

4040
async function run() {
4141
const startTime = Date.now();
42-
const onlyBrowserVersions = process.argv.includes('--only-browser-versions');
4342

4443
/** @type {!Array<!Message>} */
4544
const messages = [];
@@ -141,21 +140,19 @@ async function run() {
141140
libversion: VERSION,
142141
chromiumVersion: browserVersions.chromium,
143142
firefoxVersion: browserVersions.firefox,
144-
onlyBrowserVersions,
145143
})));
146144

147-
if (!onlyBrowserVersions) {
148-
messages.push(...preprocessor.autocorrectInvalidLinks(PROJECT_DIR, mdSources, getRepositoryFiles()));
149-
for (const source of mdSources.filter(source => source.hasUpdatedText()))
150-
messages.push(Message.warning(`WARN: updated ${source.projectPath()}`));
151-
152-
const browser = await playwright.chromium.launch();
153-
const page = await browser.newPage();
154-
const checkPublicAPI = require('./check_public_api');
155-
const jsSources = await Source.readdir(path.join(PROJECT_DIR, 'src', 'client'), '', []);
156-
messages.push(...await checkPublicAPI(page, [api], jsSources));
157-
await browser.close();
158-
}
145+
messages.push(...preprocessor.autocorrectInvalidLinks(PROJECT_DIR, mdSources, getRepositoryFiles()));
146+
147+
for (const source of mdSources.filter(source => source.hasUpdatedText()))
148+
messages.push(Message.warning(`WARN: updated ${source.projectPath()}`));
149+
150+
const browser = await playwright.chromium.launch();
151+
const page = await browser.newPage();
152+
const checkPublicAPI = require('./check_public_api');
153+
const jsSources = await Source.readdir(path.join(PROJECT_DIR, 'src', 'client'), '', []);
154+
messages.push(...await checkPublicAPI(page, [api], jsSources));
155+
await browser.close();
159156

160157
for (const source of mdSources) {
161158
if (!source.hasUpdatedText())
@@ -193,7 +190,7 @@ async function run() {
193190
console.log(`${errors.length} failures, ${warnings.length} warnings.`);
194191
const runningTime = Date.now() - startTime;
195192
console.log(`DocLint Finished in ${runningTime / 1000} seconds`);
196-
process.exit(clearExit || onlyBrowserVersions ? 0 : 1);
193+
process.exit(clearExit ? 0 : 1);
197194
}
198195

199196
async function getBrowserVersions() {

utils/doclint/preprocessor/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
const path = require('path');
1818
const Message = require('../Message');
1919

20-
function runCommands(sources, {libversion, chromiumVersion, firefoxVersion, onlyBrowserVersions}) {
20+
function runCommands(sources, {libversion, chromiumVersion, firefoxVersion}) {
2121
// Release version is everything that doesn't include "-".
2222
const isReleaseVersion = !libversion.includes('-');
2323

@@ -51,8 +51,6 @@ function runCommands(sources, {libversion, chromiumVersion, firefoxVersion, only
5151
newText = `[![Chromium version](https://img.shields.io/badge/chromium-${chromiumVersion}-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)`;
5252
else if (commandName === 'firefox-version-badge')
5353
newText = `[![Firefox version](https://img.shields.io/badge/firefox-${firefoxVersion}-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/)`;
54-
else if (onlyBrowserVersions)
55-
continue;
5654
else if (commandName === 'version')
5755
newText = isReleaseVersion ? 'v' + libversion : 'Tip-Of-Tree';
5856
else if (commandName === 'toc')

utils/roll_browser.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ Example:
8282
// 5. Update docs.
8383
console.log('\nUpdating documentation...');
8484
try {
85-
process.stdout.write(execSync('npm run --silent doc -- --only-browser-versions'));
85+
process.stdout.write(execSync('npm run --silent doc'));
8686
} catch (e) {
8787
}
8888

0 commit comments

Comments
 (0)