Skip to content

Commit b9dcfb9

Browse files
authored
test: minor fixes (#4024)
- missing await - missing `defaultBrowserOptions` that's important to respect `FFPATH` (and other custom browsers)
1 parent 13d48da commit b9dcfb9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

test/channels.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,8 @@ it('should scope browser handles', async ({browserType, defaultBrowserOptions})
162162
await expectScopeState(browserType, GOLDEN_PRECONDITION);
163163
});
164164

165-
it('should work with the domain module', async ({ domain, browserType }) => {
166-
const browser = await browserType.launch();
165+
it('should work with the domain module', async ({ domain, browserType, defaultBrowserOptions }) => {
166+
const browser = await browserType.launch(defaultBrowserOptions);
167167
const page = await browser.newPage();
168168
const result = await page.evaluate(() => 1 + 1);
169169
expect(result).toBe(2);

test/downloads-path.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ defineTestFixture('persistentDownloadsContext', async ({server, launchPersistent
5252
acceptDownloads: true
5353
}
5454
);
55-
page.setContent(`<a href="${server.PREFIX}/download">download</a>`);
55+
await page.setContent(`<a href="${server.PREFIX}/download">download</a>`);
5656
await test(context);
5757
await context.close();
5858
});

0 commit comments

Comments
 (0)