Skip to content

Commit b4b7c5e

Browse files
authored
feat(webkit): enable user-data-dir tests for all platforms (#646)
Fixes #560
1 parent 63d5a73 commit b4b7c5e

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"playwright": {
1111
"chromium_revision": "733125",
1212
"firefox_revision": "1018",
13-
"webkit_revision": "1111"
13+
"webkit_revision": "1112"
1414
},
1515
"scripts": {
1616
"unit": "node test/test.js",

src/server/webkit.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@ export class WebKit implements BrowserType {
7979

8080
let userDataDir: string;
8181
let temporaryUserDataDir: string | null = null;
82-
const userDataDirArg = webkitArguments.find(arg => arg.startsWith('--user-data-dir'));
82+
const userDataDirArg = webkitArguments.find(arg => arg.startsWith('--user-data-dir='));
8383
if (userDataDirArg) {
84-
userDataDir = userDataDirArg.substr('--user-data-dir'.length).trim();
84+
userDataDir = userDataDirArg.substr('--user-data-dir='.length).trim();
8585
} else {
8686
userDataDir = await mkdtempAsync(WEBKIT_PROFILE_PATH);
8787
temporaryUserDataDir = userDataDir;

test/launcher.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
288288
});
289289
});
290290

291-
describe.skip(WEBKIT)('Playwright.launch({userDataDir})', function() {
291+
describe('Playwright.launch({userDataDir})', function() {
292292
it('userDataDir option', async({server}) => {
293293
const userDataDir = await mkdtempAsync(TMP_FOLDER);
294294
const options = Object.assign({userDataDir}, defaultBrowserOptions);

0 commit comments

Comments
 (0)