fix: report hash in page.url() (#2252)

Fixes #2247

Author: aslushnikov

src/chromium/crPage.ts

@@ -500,7 +500,7 @@ class FrameSession {
   }
 
   _onFrameNavigated(framePayload: Protocol.Page.Frame, initial: boolean) {
-    this._page._frameManager.frameCommittedNewDocumentNavigation(framePayload.id, framePayload.url, framePayload.name || '', framePayload.loaderId, initial);
+    this._page._frameManager.frameCommittedNewDocumentNavigation(framePayload.id, framePayload.url + (framePayload.urlFragment || ''), framePayload.name || '', framePayload.loaderId, initial);
     if (!initial)
       this._firstNonInitialNavigationCommittedFulfill();
   }

test/page.spec.js

@@ -780,6 +780,14 @@ describe('Page.url', function() {
     await page.goto(server.EMPTY_PAGE);
     expect(page.url()).toBe(server.EMPTY_PAGE);
   });
+  it('should include hashes', async({page, server}) => {
+    await page.goto(server.EMPTY_PAGE + '#hash');
+    expect(page.url()).toBe(server.EMPTY_PAGE + '#hash');
+    await page.evaluate(() => {
+      window.location.hash = "dynamic";
+    });
+    expect(page.url()).toBe(server.EMPTY_PAGE + '#dynamic');
+  });
 });
 
 describe('Page.title', function() {

test/popup.spec.js

@@ -263,7 +263,8 @@ describe('Page.Events.Popup', function() {
       page.waitForEvent('popup'),
       page.evaluate(() => window.__popup = window.open(undefined, null, 'noopener')),
     ]);
-    expect(popup.url()).toBe('about:blank');
+    // Chromium reports `about:blank#blocked` here.
+    expect(popup.url().split('#')[0]).toBe('about:blank');
     expect(await page.evaluate(() => !!window.opener)).toBe(false);
     expect(await popup.evaluate(() => !!window.opener)).toBe(false);
     await context.close();