Skip to content

Commit 920cc7c

Browse files
authored
test: run crash tests with chromium wire (#4026)
1 parent b74a6b7 commit 920cc7c

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

test/page-event-crash.spec.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ function crash(page, toImpl, browserName) {
2727
}
2828

2929
describe('', (suite, { browserName, platform, wire }) => {
30-
suite.fixme(wire);
30+
suite.skip(wire && browserName !== 'chromium');
3131
suite.flaky(browserName === 'firefox' && platform === 'win32');
3232
}, () => {
3333
it('should emit crash event when page crashes', async ({page, browserName, toImpl}) => {
@@ -63,10 +63,7 @@ describe('', (suite, { browserName, platform, wire }) => {
6363
expect(error.message).toContain('Navigation failed because page crashed');
6464
});
6565

66-
it('should be able to close context when page crashes', (test, { browserName, platform, wire }) => {
67-
test.fixme(wire);
68-
test.flaky(browserName === 'firefox' && platform === 'win32');
69-
}, async ({page, browserName, toImpl}) => {
66+
it('should be able to close context when page crashes', async ({page, browserName, toImpl}) => {
7067
await page.setContent(`<div>This page should crash</div>`);
7168
crash(page, toImpl, browserName);
7269
await page.waitForEvent('crash');

0 commit comments

Comments
 (0)