Skip to content

Commit 8770c64

Browse files
authored
browser(webkit): fix mac compilation after latest roll (#6727)
1 parent 2321abb commit 8770c64

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

browser_patches/webkit/BUILD_NUMBER

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
1483
2-
Changed: [email protected] Mon 24 May 2021 12:26:08 PM PDT
1+
1484
2+
Changed: [email protected] Mon 24 May 2021 02:43:11 PM PDT

browser_patches/webkit/patches/bootstrap.diff

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11965,10 +11965,10 @@ index 0000000000000000000000000000000000000000..4ec8b96bbbddf8a7b042f53a8068754a
1196511965
+cairo_status_t cairo_image_surface_write_to_jpeg_mem(cairo_surface_t *sfc, unsigned char **data, size_t *len, int quality);
1196611966
diff --git a/Source/WebKit/UIProcess/Inspector/Agents/InspectorScreencastAgent.cpp b/Source/WebKit/UIProcess/Inspector/Agents/InspectorScreencastAgent.cpp
1196711967
new file mode 100644
11968-
index 0000000000000000000000000000000000000000..911f4f8f3eb0aa66fe6d11bb46a5f836febc5c60
11968+
index 0000000000000000000000000000000000000000..b30668cc6dfc1d090600980d9ff1da5ed52902aa
1196911969
--- /dev/null
1197011970
+++ b/Source/WebKit/UIProcess/Inspector/Agents/InspectorScreencastAgent.cpp
11971-
@@ -0,0 +1,272 @@
11971+
@@ -0,0 +1,271 @@
1197211972
+/*
1197311973
+ * Copyright (C) 2020 Microsoft Corporation.
1197411974
+ *
@@ -12219,10 +12219,9 @@ index 0000000000000000000000000000000000000000..911f4f8f3eb0aa66fe6d11bb46a5f836
1221912219
+ }
1222012220
+ auto cfData = adoptCF(CFDataCreateMutable(kCFAllocatorDefault, 0));
1222112221
+ WebCore::encodeImage(imagePtr, CFSTR("public.jpeg"), m_screencastQuality * 0.1, cfData.get());
12222-
+ Vector<char> base64Data;
12223-
+ base64Encode(CFDataGetBytePtr(cfData.get()), CFDataGetLength(cfData.get()), base64Data);
12222+
+ String base64Data = base64EncodeToString(CFDataGetBytePtr(cfData.get()), CFDataGetLength(cfData.get()));
1222412223
+ ++m_screencastFramesInFlight;
12225-
+ m_frontendDispatcher->screencastFrame(String(base64Data.data(), base64Data.size()), displaySize.width(), displaySize.height());
12224+
+ m_frontendDispatcher->screencastFrame(base64Data, displaySize.width(), displaySize.height());
1222612225
+ }
1222712226
+ if (m_encoder)
1222812227
+ m_encoder->encodeFrame(WTFMove(imageRef));

tests/chromium/js-coverage.spec.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@
1616

1717
import { contextTest as it, expect } from '../config/browserTest';
1818

19-
it('should work', async function({page, server}) {
19+
it.only('should work', async function({page, server}) {
2020
await page.coverage.startJSCoverage();
21-
await page.goto(server.PREFIX + '/jscoverage/simple.html', { waitUntil: 'load' });
21+
await page.goto(server.PREFIX + '/jscoverag e/simple.html', { waitUntil: 'load' });
2222
const coverage = await page.coverage.stopJSCoverage();
23+
console.log(JSON.stringify(coverage, null, 2));
2324
expect(coverage.length).toBe(1);
2425
expect(coverage[0].url).toContain('/jscoverage/simple.html');
2526
expect(coverage[0].functions.find(f => f.functionName === 'foo').ranges[0].count).toEqual(1);

0 commit comments

Comments
 (0)