chore(autowait): auto-wait for top level navigations only (#5861)

pavelfeldman · web-flow · commit 84efdfcbc9f6 · 2021-03-17T14:47:51.000-07:00
diff --git a/src/server/frames.ts b/src/server/frames.ts
@@ -1243,6 +1243,9 @@ class SignalBarrier {
   }
 
   async addFrameNavigation(frame: Frame) {
+    // Auto-wait top-level navigations only.
+    if (frame.parentFrame())
+      return;
     this.retain();
     const waiter = helper.waitForEvent(null, frame, Frame.Events.Navigation, (e: NavigationEvent) => {
       if (!e.error && this._progress)

Original file line number	Diff line number	Diff line change
`@@ -1243,6 +1243,9 @@ class SignalBarrier {`
`1243`	`1243`	`}`
`1244`	`1244`
`1245`	`1245`	`async addFrameNavigation(frame: Frame) {`
	`1246`	`+ // Auto-wait top-level navigations only.`
	`1247`	`+ if (frame.parentFrame())`
	`1248`	`+ return;`
`1246`	`1249`	`this.retain();`
`1247`	`1250`	`const waiter = helper.waitForEvent(null, frame, Frame.Events.Navigation, (e: NavigationEvent) => {`
`1248`	`1251`	`if (!e.error && this._progress)`