Skip to content

Commit 7e8d03b

Browse files
authored
fix(launcher): extend list of known missing DLLs (#3256)
#2745
1 parent 8709ad7 commit 7e8d03b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/server/validateDependencies.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ async function validateDependenciesWindows(browserPath: string, browser: Browser
6565
let isCrtMissing = false;
6666
let isMediaFoundationMissing = false;
6767
for (const dep of missingDeps) {
68-
if (dep.startsWith('api-ms-win-crt'))
68+
if (dep.startsWith('api-ms-win-crt') || dep === 'vcruntime140.dll' || dep === 'msvcp140.dll')
6969
isCrtMissing = true;
70-
else if (dep === 'mf.dll' || dep === 'mfplat.dll' || dep === 'msmpeg2vdec.dll')
70+
else if (dep === 'mf.dll' || dep === 'mfplat.dll' || dep === 'msmpeg2vdec.dll' || dep === 'evr.dll' || dep === 'avrt.dll')
7171
isMediaFoundationMissing = true;
7272
}
7373

@@ -211,7 +211,7 @@ async function missingFileDependencies(filePath: string): Promise<Array<string>>
211211
});
212212
if (code !== 0)
213213
return [];
214-
const missingDeps = stdout.split('\n').map(line => line.trim()).filter(line => line.endsWith('not found') && line.includes('=>')).map(line => line.split('=>')[0].trim());
214+
const missingDeps = stdout.split('\n').map(line => line.trim()).filter(line => line.endsWith('not found') && line.includes('=>')).map(line => line.split('=>')[0].trim().toLowerCase());
215215
return missingDeps;
216216
}
217217

0 commit comments

Comments
 (0)