Skip to content

Commit 791443d

Browse files
authored
feat(webkit): roll to r1472 (#6425)
1 parent 477b93b commit 791443d

File tree

3 files changed

+55
-11
lines changed

3 files changed

+55
-11
lines changed

browsers.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
},
1919
{
2020
"name": "webkit",
21-
"revision": "1468",
21+
"revision": "1472",
2222
"installByDefault": true,
2323
"revisionOverrides": {
2424
"mac10.14": "1443"

src/server/webkit/protocol.ts

Lines changed: 52 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8031,11 +8031,19 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the
80318031
*/
80328032
export type ScreencastId = string;
80338033

8034+
export type screencastFramePayload = {
8035+
/**
8036+
* Base64 data
8037+
*/
8038+
data: string;
8039+
deviceWidth: number;
8040+
deviceHeight: number;
8041+
}
80348042

80358043
/**
80368044
* Starts recoring video to speified file.
80378045
*/
8038-
export type startParameters = {
8046+
export type startVideoParameters = {
80398047
/**
80408048
* Output file location.
80418049
*/
@@ -8044,7 +8052,7 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the
80448052
height: number;
80458053
scale?: number;
80468054
}
8047-
export type startReturnValue = {
8055+
export type startVideoReturnValue = {
80488056
/**
80498057
* Unique identifier of the screencast.
80508058
*/
@@ -8053,9 +8061,38 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the
80538061
/**
80548062
* Stops recoding video. Returns after the file has been closed.
80558063
*/
8056-
export type stopParameters = {
8064+
export type stopVideoParameters = {
80578065
}
8058-
export type stopReturnValue = {
8066+
export type stopVideoReturnValue = {
8067+
}
8068+
/**
8069+
* Starts screencast.
8070+
*/
8071+
export type startScreencastParameters = {
8072+
width: number;
8073+
height: number;
8074+
quality: number;
8075+
}
8076+
export type startScreencastReturnValue = {
8077+
/**
8078+
* Screencast session generation.
8079+
*/
8080+
generation: number;
8081+
}
8082+
/**
8083+
* Stops screencast.
8084+
*/
8085+
export type stopScreencastParameters = {
8086+
}
8087+
export type stopScreencastReturnValue = {
8088+
}
8089+
export type screencastFrameAckParameters = {
8090+
/**
8091+
* Screencast session generation
8092+
*/
8093+
generation: number;
8094+
}
8095+
export type screencastFrameAckReturnValue = {
80598096
}
80608097
}
80618098

@@ -8612,6 +8649,7 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the
86128649
"Playwright.downloadFinished": Playwright.downloadFinishedPayload;
86138650
"Playwright.screencastFinished": Playwright.screencastFinishedPayload;
86148651
"Runtime.executionContextCreated": Runtime.executionContextCreatedPayload;
8652+
"Screencast.screencastFrame": Screencast.screencastFramePayload;
86158653
"ScriptProfiler.trackingStart": ScriptProfiler.trackingStartPayload;
86168654
"ScriptProfiler.trackingUpdate": ScriptProfiler.trackingUpdatePayload;
86178655
"ScriptProfiler.trackingComplete": ScriptProfiler.trackingCompletePayload;
@@ -8895,8 +8933,11 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the
88958933
"Runtime.enableControlFlowProfiler": Runtime.enableControlFlowProfilerParameters;
88968934
"Runtime.disableControlFlowProfiler": Runtime.disableControlFlowProfilerParameters;
88978935
"Runtime.getBasicBlocks": Runtime.getBasicBlocksParameters;
8898-
"Screencast.start": Screencast.startParameters;
8899-
"Screencast.stop": Screencast.stopParameters;
8936+
"Screencast.startVideo": Screencast.startVideoParameters;
8937+
"Screencast.stopVideo": Screencast.stopVideoParameters;
8938+
"Screencast.startScreencast": Screencast.startScreencastParameters;
8939+
"Screencast.stopScreencast": Screencast.stopScreencastParameters;
8940+
"Screencast.screencastFrameAck": Screencast.screencastFrameAckParameters;
89008941
"ScriptProfiler.startTracking": ScriptProfiler.startTrackingParameters;
89018942
"ScriptProfiler.stopTracking": ScriptProfiler.stopTrackingParameters;
89028943
"ServiceWorker.getInitializationInfo": ServiceWorker.getInitializationInfoParameters;
@@ -9184,8 +9225,11 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the
91849225
"Runtime.enableControlFlowProfiler": Runtime.enableControlFlowProfilerReturnValue;
91859226
"Runtime.disableControlFlowProfiler": Runtime.disableControlFlowProfilerReturnValue;
91869227
"Runtime.getBasicBlocks": Runtime.getBasicBlocksReturnValue;
9187-
"Screencast.start": Screencast.startReturnValue;
9188-
"Screencast.stop": Screencast.stopReturnValue;
9228+
"Screencast.startVideo": Screencast.startVideoReturnValue;
9229+
"Screencast.stopVideo": Screencast.stopVideoReturnValue;
9230+
"Screencast.startScreencast": Screencast.startScreencastReturnValue;
9231+
"Screencast.stopScreencast": Screencast.stopScreencastReturnValue;
9232+
"Screencast.screencastFrameAck": Screencast.screencastFrameAckReturnValue;
91899233
"ScriptProfiler.startTracking": ScriptProfiler.startTrackingReturnValue;
91909234
"ScriptProfiler.stopTracking": ScriptProfiler.stopTrackingReturnValue;
91919235
"ServiceWorker.getInitializationInfo": ServiceWorker.getInitializationInfoReturnValue;

src/server/webkit/wkPage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,7 @@ export class WKPage implements PageDelegate {
737737

738738
async _startScreencast(options: types.PageScreencastOptions): Promise<void> {
739739
assert(!this._recordingVideoFile);
740-
const { screencastId } = await this._pageProxySession.send('Screencast.start', {
740+
const { screencastId } = await this._pageProxySession.send('Screencast.startVideo', {
741741
file: options.outputFile,
742742
width: options.width,
743743
height: options.height,
@@ -749,7 +749,7 @@ export class WKPage implements PageDelegate {
749749
async _stopScreencast(): Promise<void> {
750750
if (!this._recordingVideoFile)
751751
return;
752-
await this._pageProxySession.sendMayFail('Screencast.stop');
752+
await this._pageProxySession.sendMayFail('Screencast.stopVideo');
753753
this._recordingVideoFile = null;
754754
}
755755

0 commit comments

Comments
 (0)