Skip to content

Commit 68c4f79

Browse files
authored
feat(rpc): convert protocol to yaml (#3102)
1 parent b1a5a02 commit 68c4f79

File tree

7 files changed

+2077
-1723
lines changed

7 files changed

+2077
-1723
lines changed

package-lock.json

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@
8282
"ts-loader": "^6.1.2",
8383
"typescript": "^3.8.3",
8484
"webpack": "^4.41.0",
85-
"webpack-cli": "^3.3.9"
85+
"webpack-cli": "^3.3.9",
86+
"yaml": "^1.10.0"
8687
}
8788
}

src/rpc/channels.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -352,6 +352,8 @@ export interface BrowserContextChannel extends Channel {
352352
on(event: 'close', callback: (params: BrowserContextCloseEvent) => void): this;
353353
on(event: 'page', callback: (params: BrowserContextPageEvent) => void): this;
354354
on(event: 'route', callback: (params: BrowserContextRouteEvent) => void): this;
355+
on(event: 'crBackgroundPage', callback: (params: BrowserContextCrBackgroundPageEvent) => void): this;
356+
on(event: 'crServiceWorker', callback: (params: BrowserContextCrServiceWorkerEvent) => void): this;
355357
addCookies(params: BrowserContextAddCookiesParams): Promise<BrowserContextAddCookiesResult>;
356358
addInitScript(params: BrowserContextAddInitScriptParams): Promise<BrowserContextAddInitScriptResult>;
357359
clearCookies(params?: BrowserContextClearCookiesParams): Promise<BrowserContextClearCookiesResult>;
@@ -368,8 +370,6 @@ export interface BrowserContextChannel extends Channel {
368370
setHTTPCredentials(params: BrowserContextSetHTTPCredentialsParams): Promise<BrowserContextSetHTTPCredentialsResult>;
369371
setNetworkInterceptionEnabled(params: BrowserContextSetNetworkInterceptionEnabledParams): Promise<BrowserContextSetNetworkInterceptionEnabledResult>;
370372
setOffline(params: BrowserContextSetOfflineParams): Promise<BrowserContextSetOfflineResult>;
371-
on(event: 'crBackgroundPage', callback: (params: BrowserContextCrBackgroundPageEvent) => void): this;
372-
on(event: 'crServiceWorker', callback: (params: BrowserContextCrServiceWorkerEvent) => void): this;
373373
crNewCDPSession(params: BrowserContextCrNewCDPSessionParams): Promise<BrowserContextCrNewCDPSessionResult>;
374374
}
375375
export type BrowserContextBindingCallEvent = {
@@ -383,6 +383,12 @@ export type BrowserContextRouteEvent = {
383383
route: RouteChannel,
384384
request: RequestChannel,
385385
};
386+
export type BrowserContextCrBackgroundPageEvent = {
387+
page: PageChannel,
388+
};
389+
export type BrowserContextCrServiceWorkerEvent = {
390+
worker: WorkerChannel,
391+
};
386392
export type BrowserContextAddCookiesParams = {
387393
cookies: {
388394
name: string,
@@ -473,12 +479,6 @@ export type BrowserContextSetOfflineParams = {
473479
offline: boolean,
474480
};
475481
export type BrowserContextSetOfflineResult = void;
476-
export type BrowserContextCrBackgroundPageEvent = {
477-
page: PageChannel,
478-
};
479-
export type BrowserContextCrServiceWorkerEvent = {
480-
worker: WorkerChannel,
481-
};
482482
export type BrowserContextCrNewCDPSessionParams = {
483483
page: PageChannel,
484484
};

src/rpc/client/validator.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,12 @@ scheme.BrowserContextRouteEvent = tObject({
314314
route: tChannel('Route'),
315315
request: tChannel('Request'),
316316
});
317+
scheme.BrowserContextCrBackgroundPageEvent = tObject({
318+
page: tChannel('Page'),
319+
});
320+
scheme.BrowserContextCrServiceWorkerEvent = tObject({
321+
worker: tChannel('Worker'),
322+
});
317323
scheme.BrowserContextAddCookiesParams = tObject({
318324
cookies: tArray(tObject({
319325
name: tString,
@@ -404,12 +410,6 @@ scheme.BrowserContextSetOfflineParams = tObject({
404410
offline: tBoolean,
405411
});
406412
scheme.BrowserContextSetOfflineResult = tUndefined;
407-
scheme.BrowserContextCrBackgroundPageEvent = tObject({
408-
page: tChannel('Page'),
409-
});
410-
scheme.BrowserContextCrServiceWorkerEvent = tObject({
411-
worker: tChannel('Worker'),
412-
});
413413
scheme.BrowserContextCrNewCDPSessionParams = tObject({
414414
page: tChannel('Page'),
415415
});

0 commit comments

Comments
 (0)