Skip to content

Commit 6105d8a

Browse files
fix(tests): fix test that was leaking a context (#933)
1 parent aae5fca commit 6105d8a

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

test/browser.spec.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
4242
const page = await browser.newPage();
4343
let error;
4444
await page.context().newPage().catch(e => error = e);
45+
await page.close();
4546
expect(error.message).toContain('Please use browser.newContext()');
4647
});
4748
});

test/playwright.spec.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ module.exports.describe = ({testRunner, product, playwrightPath}) => {
118118

119119
state.tearDown = async () => {
120120
await Promise.all(contexts.map(c => c.close()));
121+
expect((await state.browser.contexts()).length).toBe(0, `"${test.fullName}" leaked a context`);
121122
if (rl) {
122123
rl.removeListener('line', onLine);
123124
rl.close();

0 commit comments

Comments
 (0)